| Message ID | 200911202152.22910.sshtylyov@ru.mvista.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Fri, 20 Nov 2009 22:52:22 +0400 Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > Alan Cox reported that cable detection sometimes works unreliably > for HPT3xxN and that the issue is fixed by adding debounce delay > as used by the vendor drivers. > > While at it, get rid of unneeded parens/space in the vicinity... > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > Cc: stable@kernel.org Acked-by: Alan Cox <alan@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, I wrote: > Alan Cox reported that cable detection sometimes works unreliably > for HPT3xxN and that the issue is fixed by adding debounce delay > as used by the vendor drivers. > While at it, get rid of unneeded parens/space in the vicinity... > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > Cc: stable@kernel.org David, will you (finally) apply this patch? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. I wrote: >> Alan Cox reported that cable detection sometimes works unreliably >> for HPT3xxN and that the issue is fixed by adding debounce delay >> as used by the vendor drivers. >> While at it, get rid of unneeded parens/space in the vicinity... >> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> >> Cc: stable@kernel.org > David, will you (finally) apply this patch? Well, nine months has passed, and I have to ask again -- are you going to at last apply it? :-/ MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: ide-2.6/drivers/ide/hpt366.c =================================================================== --- ide-2.6.orig/drivers/ide/hpt366.c +++ ide-2.6/drivers/ide/hpt366.c @@ -1236,8 +1236,9 @@ static u8 hpt3xx_cable_detect(ide_hwif_t u16 mcr; pci_read_config_word(dev, mcr_addr, &mcr); - pci_write_config_word(dev, mcr_addr, (mcr | 0x8000)); - /* now read cable id register */ + pci_write_config_word(dev, mcr_addr, mcr | 0x8000); + /* Debounce, then read cable ID register */ + udelay(10); pci_read_config_byte(dev, 0x5a, &scr1); pci_write_config_word(dev, mcr_addr, mcr); } else if (chip_type >= HPT370) { @@ -1248,10 +1249,11 @@ static u8 hpt3xx_cable_detect(ide_hwif_t u8 scr2 = 0; pci_read_config_byte(dev, 0x5b, &scr2); - pci_write_config_byte(dev, 0x5b, (scr2 & ~1)); - /* now read cable id register */ + pci_write_config_byte(dev, 0x5b, scr2 & ~1); + /* Debounce, then read cable ID register */ + udelay(10); pci_read_config_byte(dev, 0x5a, &scr1); - pci_write_config_byte(dev, 0x5b, scr2); + pci_write_config_byte(dev, 0x5b, scr2); } else pci_read_config_byte(dev, 0x5a, &scr1);
Alan Cox reported that cable detection sometimes works unreliably for HPT3xxN and that the issue is fixed by adding debounce delay as used by the vendor drivers. While at it, get rid of unneeded parens/space in the vicinity... Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: stable@kernel.org --- The patcn is atop of ide-2.6.git tree... drivers/ide/hpt366.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html