Message ID | 200911192031.31613.bzolnier@gmail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > --- > In comparison to original patch the conversion from PCI access to > io has been dropped as it is not required for the bugfix and makes > patch easier for back-porting into -stable kernels. Acked-by: Alan Cox <alan@linux.intel.com> (and from what Sergey says about the 371N then the I/O conversion is probably not needed anyway) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 19 November 2009 20:42:13 Alan Cox wrote: > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > --- > > In comparison to original patch the conversion from PCI access to > > io has been dropped as it is not required for the bugfix and makes > > patch easier for back-porting into -stable kernels. > > Acked-by: Alan Cox <alan@linux.intel.com> > > (and from what Sergey says about the 371N then the I/O conversion > is probably not needed anyway) Thanks, I'll re-sync other pata_hpt37x patches on top of this one later. ps if you could also push the fix to hpt366.c it would be great
On 11/19/2009 02:31 PM, Bartlomiej Zolnierkiewicz wrote: > Jeff, this is incremental to my previous fix. > > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > Subject: [PATCH] pata_hpt{37x,3x2n}: add debounce delay to cable detection methods PLEASE update the email subject, in future emails, to reflect a patch is buried in here! Thanks, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/19/2009 02:31 PM, Bartlomiej Zolnierkiewicz wrote: > Subject: [PATCH] pata_hpt{37x,3x2n}: add debounce delay to cable detection methods > > Alan Cox reported that cable detection sometimes works unreliably > for HPT3xxN and that the issue is fixed by adding debounce delay > as used by the vendor driver. > > Sergei Shtylyov also noticed that debounce delay is needed for all > HPT37x and HPT3xxN chipsets according to vendor drivers. > > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > --- > In comparison to original patch the conversion from PCI access to > io has been dropped as it is not required for the bugfix and makes > patch easier for back-porting into -stable kernels. > > drivers/ata/pata_hpt37x.c | 3 +++ > drivers/ata/pata_hpt3x2n.c | 3 +++ > 2 files changed, 6 insertions(+) > > Index: b/drivers/ata/pata_hpt37x.c > =================================================================== > --- a/drivers/ata/pata_hpt37x.c > +++ b/drivers/ata/pata_hpt37x.c > @@ -324,6 +324,9 @@ static int hpt37x_pre_reset(struct ata_l > > pci_read_config_byte(pdev, 0x5B,&scr2); > pci_write_config_byte(pdev, 0x5B, scr2& ~0x01); > + > + udelay(10); /* debounce */ > + > /* Cable register now active */ > pci_read_config_byte(pdev, 0x5A,&ata66); > /* Restore state */ > Index: b/drivers/ata/pata_hpt3x2n.c > =================================================================== > --- a/drivers/ata/pata_hpt3x2n.c > +++ b/drivers/ata/pata_hpt3x2n.c > @@ -128,6 +128,9 @@ static int hpt3x2n_cable_detect(struct a > > pci_read_config_byte(pdev, 0x5B,&scr2); > pci_write_config_byte(pdev, 0x5B, scr2& ~0x01); > + > + udelay(10); /* debounce */ > + > /* Cable register now active */ > pci_read_config_byte(pdev, 0x5A,&ata66); > /* Restore state */ applied -- same comment as last email, regarding hpt3x2n_cable_detect() fix -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_hpt37x.c =================================================================== --- a/drivers/ata/pata_hpt37x.c +++ b/drivers/ata/pata_hpt37x.c @@ -324,6 +324,9 @@ static int hpt37x_pre_reset(struct ata_l pci_read_config_byte(pdev, 0x5B, &scr2); pci_write_config_byte(pdev, 0x5B, scr2 & ~0x01); + + udelay(10); /* debounce */ + /* Cable register now active */ pci_read_config_byte(pdev, 0x5A, &ata66); /* Restore state */ Index: b/drivers/ata/pata_hpt3x2n.c =================================================================== --- a/drivers/ata/pata_hpt3x2n.c +++ b/drivers/ata/pata_hpt3x2n.c @@ -128,6 +128,9 @@ static int hpt3x2n_cable_detect(struct a pci_read_config_byte(pdev, 0x5B, &scr2); pci_write_config_byte(pdev, 0x5B, scr2 & ~0x01); + + udelay(10); /* debounce */ + /* Cable register now active */ pci_read_config_byte(pdev, 0x5A, &ata66); /* Restore state */