diff mbox

[v2,1/3] RTC: fm3130 fix

Message ID 1256408743-6644-1-git-send-email-geomatsi@gmail.com
State Changes Requested, archived
Headers show

Commit Message

Sergey Matyukevich Oct. 24, 2009, 6:25 p.m. UTC 
Add missing braces for multiline 'if' statements in fm3130_probe.
---
 drivers/rtc/rtc-fm3130.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Comments

Sergey Lapin Oct. 24, 2009, 7:19 p.m. UTC | #1 
On Sat, Oct 24, 2009 at 10:25:41PM +0400, Sergey Matyukevich wrote:
> Add missing braces for multiline 'if' statements in fm3130_probe.
> ---
>  drivers/rtc/rtc-fm3130.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

This is trivial bugfix-only patch, hopefully can be submitted.
Acked-by: Sergey Lapin <slapin@ossfans.org>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Alessandro Zummo Nov. 18, 2009, 3:19 p.m. UTC | #2 
On Sat, 24 Oct 2009 22:25:41 +0400
Sergey Matyukevich <geomatsi@gmail.com> wrote:

> Add missing braces for multiline 'if' statements in fm3130_probe.

 Please resubmit the series adding your Signed-of-by line
 and checking each patch with checkpatch.pl
Sergey Matyukevich Nov. 18, 2009, 7:45 p.m. UTC | #3 
Hi Alessandro,

Here is updated patch series for fm3130 driver.
Signed-of-by lines are added and all three patches 
are checked using checkpatch script.

Thanks,
Sergey
Sergey Matyukevich Dec. 16, 2009, 8:12 a.m. UTC | #4 
Hi Alessandro,

A couple of weeks ago I resubmitted this patch series providing
required modifications and checks. I haven't yet got any answer,
neither ack or nack. Could you please take a look at that patch
series ?
Just let me know if anything is missing this time so that I can fix it
and resubmit again.

Thanks,
Sergey

On 18 ноя, 18:19, Alessandro Zummo <azummo-li...@towertech.it> wrote:
> On Sat, 24 Oct 2009 22:25:41 +0400
>
> Sergey Matyukevich <geoma...@gmail.com> wrote:
> > Add missing braces for multiline 'if' statements in fm3130_probe.
>
>  Please resubmit the series adding your Signed-of-by line
>  and checking each patch with checkpatch.pl
>
> --
>
>  Best regards,
>
>  Alessandro Zummo,
>   Tower Technologies - Torino, Italy
>
>  http://www.towertech.it
Alessandro Zummo Dec. 16, 2009, 8:43 a.m. UTC | #5 
On Wed, 16 Dec 2009 00:12:59 -0800 (PST)
matsi <geomatsi@gmail.com> wrote:

> Hi Alessandro,
> 
> A couple of weeks ago I resubmitted this patch series providing
> required modifications and checks. I haven't yet got any answer,
> neither ack or nack. Could you please take a look at that patch
> series ?
> Just let me know if anything is missing this time so that I can fix it
> and resubmit again.

 Haven't had the time. Please be sure to verify your
 code using the checklist at http://groups.google.com/group/rtc-linux/web/checklist
Sergey Matyukevich Jan. 13, 2010, 6:44 p.m. UTC | #6 
Hi, Alessandro

> > A couple of weeks ago I resubmitted this patch series providing
> > required modifications and checks. I haven't yet got any answer,
> > neither ack or nack. Could you please take a look at that patch
> > series ?
> > Just let me know if anything is missing this time so that I can fix
> > it and resubmit again.
> 
>  Haven't had the time. Please be sure to verify your
>  code using the checklist at
> http://groups.google.com/group/rtc-linux/web/checklist

Almost all the checklist options are already satisfied, since this patch
series contains fixes and enhancements for the existing rtc driver. 

The only exception is the option concerning ioctls, since second patch
contains ioctls among other enhancements. Suggested ioctls are not
absolutely necessary, however I think they are quite reasonable.
Anyway, if you decide that they are not right here, then I will remove
them. 

Meanwhile please consider at least the first patch from the series.
This patch is very simple and fixes obvious though annoying mistake -
inapropriate warning messages due to missing brackets in 'if'.


Thanks,
Sergey
diff mbox

Patch

diff --git a/drivers/rtc/rtc-fm3130.c b/drivers/rtc/rtc-fm3130.c
index 3a7be11..812c667 100644
--- a/drivers/rtc/rtc-fm3130.c
+++ b/drivers/rtc/rtc-fm3130.c
@@ -376,20 +376,22 @@  static int __devinit fm3130_probe(struct i2c_client *client,
 	}
 
 	/* Disabling calibration mode */
-	if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_CAL)
+	if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_CAL) {
 		i2c_smbus_write_byte_data(client, FM3130_RTC_CONTROL,
 			fm3130->regs[FM3130_RTC_CONTROL] &
 				~(FM3130_RTC_CONTROL_BIT_CAL));
 		dev_warn(&client->dev, "Disabling calibration mode!\n");
+	}
 
 	/* Disabling read and write modes */
 	if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_WRITE ||
-	    fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_READ)
+	    fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_READ) {
 		i2c_smbus_write_byte_data(client, FM3130_RTC_CONTROL,
 			fm3130->regs[FM3130_RTC_CONTROL] &
 				~(FM3130_RTC_CONTROL_BIT_READ |
 					FM3130_RTC_CONTROL_BIT_WRITE));
 		dev_warn(&client->dev, "Disabling READ or WRITE mode!\n");
+	}
 
 	/* oscillator off?  turn it on, so clock can tick. */
 	if (fm3130->regs[FM3130_CAL_CONTROL] & FM3130_CAL_CONTROL_BIT_nOSCEN)