Message ID | m6ep44$p04$1@ger.gmane.org |
---|---|
State | New |
Headers | show |
Wouldn't %Zu match the existing type?
On 12/12/2014 10:10 PM, Roland McGrath wrote: > Wouldn't %Zu match the existing type? > The warning is emitted with %zu or %Zu. The type of db->head->first_free is nscd_ssize_t, which is an int32_t (sysdeps/generic/nscd-types.h) and int64_t on alpha (sysdeps/alpha/nscd-types.h). Casts were added to avoid warnings in other usages of db->head->first_free in combination with dbg_log()-messages in this file (see commit-id 568470bbff2c86996cbb7ebb5411a2b5d4c46fe4).
OK, then the cast is fine.
diff --git a/nscd/mem.c b/nscd/mem.c index b4090fb..d94c6db 100644 --- a/nscd/mem.c +++ b/nscd/mem.c @@ -423,7 +423,7 @@ gc (struct database_dyn *db) if (__glibc_unlikely (debug_level >= 3)) dbg_log (_("freed %zu bytes in %s cache"), - db->head->first_free + (size_t) db->head->first_free - ((char *) moves->to + moves->size - db->data), dbnames[db - dbs]);