diff mbox

[resubmitted] Removal of duplication of -frounding-math for math tests

Message ID 0EFAB2BDD0F67E4FB6CCC8B9F87D756969CC91CC@IRSMSX103.ger.corp.intel.com
State New
Headers show

Commit Message

Zamyatin, Igor Dec. 9, 2014, 8:56 p.m. UTC 
Hi!

Resubmitting the patch with updated ChangeLog and submitter name

2014-12-09  Igor Zamyatin  <igor.zamyatin@intel.com>

        * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
        (CFLAGS-test-double.c): Likewise.
        (CFLAGS-test-ldouble.c): Likewise.
        (CPPFLAGS-test-ifloat.c): Likewise.
        (CPPFLAGS-test-idouble.c): Likewise.
        (CPPFLAGS-test-ildoubl.c): Likewise.
        (CFLAGS-test-test-fenv.c): Remove variable.
        (CFLAGS-test-misc.c): Likewise.


Is it ok?

Thanks,
Igor

> -----Original Message-----
> From: libc-alpha-owner@sourceware.org [mailto:libc-alpha-
> owner@sourceware.org] On Behalf Of Joseph Myers
> Sent: Saturday, December 06, 2014 1:37 AM
> To: Andrew Senkevich
> Cc: libc-alpha
> Subject: Re: [PATCH] Removal of duplication of -frounding-math for math
> tests
> 
> On Fri, 5 Dec 2014, Andrew Senkevich wrote:
> 
> > This patch is removal of duplication of -frounding-math for math tests
> > because it comes from math-flags in Makeconfig.
> >
> > ChangeLog
> >
> >         * math/Makefile: duplicated -frounding-math removed.
> 
> OK with a proper ChangeLog entry (which means naming each variable
> changed, along the lines of
> 
> 	* math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
> 	(CFLAGS-test-double.c): Likewise.
> 	...
> 	(CFLAGS-test-test-fenv.c): Remove variable.
> 	...
> 
> ).
> 
> --
> Joseph S. Myers
> joseph@codesourcery.com

Comments

Joseph Myers Dec. 9, 2014, 9:14 p.m. UTC | #1 
On Tue, 9 Dec 2014, Zamyatin, Igor wrote:

> Hi!
> 
> Resubmitting the patch with updated ChangeLog and submitter name
> 
> 2014-12-09  Igor Zamyatin  <igor.zamyatin@intel.com>

The name in the ChangeLog is meant to be the author name, not the 
submitter name.
diff mbox

Patch

diff --git a/math/Makefile b/math/Makefile
index 866bc0f..9ec450b 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -126,9 +126,9 @@  $(objpfx)test-ldouble.o: $(objpfx)libm-test.stmp
 $(objpfx)test-ildoubl.o: $(objpfx)libm-test.stmp
 endif
 
-CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
+CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin
 CFLAGS-test-tgmath.c = -fno-builtin
 # The following testcase uses very long lines (>3 million), so it may take a
 # while to compile it. See: http://llvm.org/bugs/show_bug.cgi?id=14106 and
@@ -136,15 +136,12 @@  CFLAGS-test-tgmath.c = -fno-builtin
 CFLAGS-test-tgmath2.c = -fno-builtin
 CFLAGS-test-tgmath-ret.c = -fno-builtin
 CFLAGS-test-powl.c = -fno-builtin
-CFLAGS-test-test-fenv.c = -frounding-math
-CFLAGS-test-misc.c = -frounding-math
 CPPFLAGS-test-ifloat.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-			 -DTEST_FAST_MATH -fno-builtin -frounding-math
+			 -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-idouble.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-			 -DTEST_FAST_MATH -fno-builtin -frounding-math
+			 -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-ildoubl.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-			  -DTEST_FAST_MATH -fno-builtin -frounding-math
-
+			  -DTEST_FAST_MATH -fno-builtin
 
 # The -lieee module sets the _LIB_VERSION_ switch to IEEE mode
 # for error handling in the -lm functions.