| Message ID | 20141206151425.0ba597cd@samsung |
|---|---|
| State | Accepted |
| Headers | show |
the added script is not what the subject/description claims it is ... On 06/12/2014 15:14, Cezary Jackiewicz wrote: > Add a script to detect the board name and populate /tmp/sysinfo. > Sets the status LED for Linksys EA4500. > > Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz@gmail.com> > --- > > diff --git a/target/linux/kirkwood/base-files/etc/diag.sh b/target/linux/kirkwood/base-files/etc/diag.sh > new file mode 100755 > index 0000000..bd6bd98 > --- /dev/null > +++ b/target/linux/kirkwood/base-files/etc/diag.sh > @@ -0,0 +1,29 @@ > +#!/bin/sh > +# Copyright (C) 2014 OpenWrt.org > + > +. /lib/functions/leds.sh > +. /lib/kirkwood.sh > + > +get_status_led() { > + case $(kirkwood_board_name) in > + ea4500) > + status_led="ea4500:white:health" > + ;; > + esac > +} > + > +set_state() { > + get_status_led > + > + case "$1" in > + preinit) > + status_led_blink_preinit > + ;; > + failsafe) > + status_led_blink_failsafe > + ;; > + done) > + status_led_on > + ;; > + esac > +} > >
Dnia 2014-12-06, o godz. 15:22:38
John Crispin <blogic@openwrt.org> napisał(a):
> the added script is not what the subject/description claims it is ...
/tmp/sysinfo is populated by calling kirkwood_board_name.
On 06/12/2014 15:26, Cezary Jackiewicz wrote: > Dnia 2014-12-06, o godz. 15:22:38 > John Crispin <blogic@openwrt.org> napisał(a): > >> the added script is not what the subject/description claims it is ... > > /tmp/sysinfo is populated by calling kirkwood_board_name. > ok, the text is a bit misleading as the script does not detect the board and populate sysinfo but calls the script ... i think the text needs to be changed before merging the patch. John
diff --git a/target/linux/kirkwood/base-files/etc/diag.sh b/target/linux/kirkwood/base-files/etc/diag.sh new file mode 100755 index 0000000..bd6bd98 --- /dev/null +++ b/target/linux/kirkwood/base-files/etc/diag.sh @@ -0,0 +1,29 @@ +#!/bin/sh +# Copyright (C) 2014 OpenWrt.org + +. /lib/functions/leds.sh +. /lib/kirkwood.sh + +get_status_led() { + case $(kirkwood_board_name) in + ea4500) + status_led="ea4500:white:health" + ;; + esac +} + +set_state() { + get_status_led + + case "$1" in + preinit) + status_led_blink_preinit + ;; + failsafe) + status_led_blink_failsafe + ;; + done) + status_led_on + ;; + esac +}
Add a script to detect the board name and populate /tmp/sysinfo. Sets the status LED for Linksys EA4500. Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz@gmail.com> ---