| Message ID | 1412160393-5848-1-git-send-email-pramod.gurav@smartplayin.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Wed, Oct 1, 2014 at 7:46 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: > This change switches to devm_request_region to request region > and hence simplifies the module unload and does away with > release_region in remove function. Your subject line should probably start with "gpio: cs5535:" Otherwise, Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 1, 2014 at 12:46 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: > This change switches to devm_request_region to request region > and hence simplifies the module unload and does away with > release_region in remove function. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> Patch applied with augmented subject. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 21, 2014 at 2:22 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Oct 1, 2014 at 12:46 PM, Pramod Gurav > <pramod.gurav@smartplayin.com> wrote: > >> This change switches to devm_request_region to request region >> and hence simplifies the module unload and does away with >> release_region in remove function. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Alexandre Courbot <gnurou@gmail.com> >> Cc: linux-gpio@vger.kernel.org >> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > > Patch applied with augmented subject. Had sent v2 of this with change in subject. But thanks for the manual change and applying. > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 92ec58f..802d518 100644 --- a/drivers/gpio/gpio-cs5535.c +++ b/drivers/gpio/gpio-cs5535.c @@ -319,7 +319,8 @@ static int cs5535_gpio_probe(struct platform_device *pdev) goto done; } - if (!request_region(res->start, resource_size(res), pdev->name)) { + if (!devm_request_region(&pdev->dev, res->start, resource_size(res), + pdev->name)) { dev_err(&pdev->dev, "can't request region\n"); goto done; } @@ -345,24 +346,18 @@ static int cs5535_gpio_probe(struct platform_device *pdev) /* finally, register with the generic GPIO API */ err = gpiochip_add(&cs5535_gpio_chip.chip); if (err) - goto release_region; + goto done; return 0; -release_region: - release_region(res->start, resource_size(res)); done: return err; } static int cs5535_gpio_remove(struct platform_device *pdev) { - struct resource *r; - gpiochip_remove(&cs5535_gpio_chip.chip); - r = platform_get_resource(pdev, IORESOURCE_IO, 0); - release_region(r->start, resource_size(r)); return 0; }
This change switches to devm_request_region to request region and hence simplifies the module unload and does away with release_region in remove function. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: linux-gpio@vger.kernel.org Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> --- drivers/gpio/gpio-cs5535.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)