diff mbox

[v3] libbsd: Enable the ARM architecture

Message ID 1412538472-5067-1-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Headers show

Commit Message

Maxime Hadjinlian Oct. 5, 2014, 7:47 p.m. UTC 
Rework the architecture support.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
v2 -> v3:
    - Change title of the commit
    - Add LIBBSD_ARCH_SUPPORT variable
    - Modify comment
v1 -> v2:
    - Remove m68k as it is currently marked broken in BR
---
 package/libbsd/Config.in | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comments

Thomas Petazzoni Oct. 5, 2014, 9:08 p.m. UTC | #1 
Dear Maxime Hadjinlian,

On Sun,  5 Oct 2014 21:47:52 +0200, Maxime Hadjinlian wrote:
> Rework the architecture support.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> v2 -> v3:
>     - Change title of the commit
>     - Add LIBBSD_ARCH_SUPPORT variable
>     - Modify comment
> v1 -> v2:
>     - Remove m68k as it is currently marked broken in BR
> ---
>  package/libbsd/Config.in | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)

Thanks, applied, after some minor rewording of the commit log.

Thomas
diff mbox

Patch

diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index e22226a..d521f05 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -1,8 +1,13 @@ 
+config BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
+	bool
+	# libbsd requires a.out.h, which is only available for those
+	# architectures: arm, x86 (and alpha, currently not supported in Buildroot;
+	# also m68k which is currently not enabled, so can't be tested.)
+	default y if BR2_arm || BR2_i386 || BR2_x86_64
+
 config BR2_PACKAGE_LIBBSD
 	bool "libbsd"
-	# libbsd requires a.out.h, which is only available for those
-	# architectures: arm, m68k, x86 (and alpha, but we don't care.)
-	depends on ( BR2_i386 || BR2_x86_64 )
+	depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	help
@@ -15,5 +20,5 @@  config BR2_PACKAGE_LIBBSD
 	  http://libbsd.freedesktop.org/
 
 comment "libbsd needs an (e)glibc toolchain w/ threads"
-	depends on ( BR2_i386 || BR2_x86_64 )
+	depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC