| Message ID | d43b465eca3e2a53c930f6e02dc4ac8b3c084693.1412143216.git.michal.simek@xilinx.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/01/2014 08:00 AM, Michal Simek wrote: > From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com> > > Calling ether_setup is redundant since alloc_etherdev calls it. > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index fda5891835d4..629077050fce 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > SET_NETDEV_DEV(ndev, &op->dev); > ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index c8fd94133ecd..4ea2d4e6f1d1 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > > SET_NETDEV_DEV(ndev, &op->dev); > -- > 1.8.2.3 > Please ignore this one it is already applied for axienet. Will send v2 just for ll_temac. Thanks, Michal
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index fda5891835d4..629077050fce 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev); ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index c8fd94133ecd..4ea2d4e6f1d1 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev);