| Message ID | 1412087049-4368-1-git-send-email-pramod.gurav@smartplayin.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Tue, 30 Sep 2014, Pramod Gurav wrote: > Get rid of using return value from gpiochip_remove() as it returns > void. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: linux-input@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> I guess this depends on some other patch that hasn't gone to Linus yet, right? As Linus' tree currently has this prototype: int gpiochip_remove(struct gpio_chip *chip)
On Wednesday 01 October 2014 12:48 PM, Jiri Kosina wrote: >> > Get rid of using return value from gpiochip_remove() as it returns >> > void. >> > >> > Cc: Linus Walleij <linus.walleij@linaro.org> >> > Cc: Alexandre Courbot <gnurou@gmail.com> >> > Cc: Jiri Kosina <jkosina@suse.cz> >> > Cc: linux-input@vger.kernel.org >> > Cc: linux-gpio@vger.kernel.org >> > >> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > I guess this depends on some other patch that hasn't gone to Linus yet, > right? As Linus' tree currently has this prototype: > > int gpiochip_remove(struct gpio_chip *chip) Yes. It is yet to make it to linus's tree. But the change is there in linux-next master branch. Thanks Pramod -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 1 Oct 2014, Pramod Gurav wrote: > >> > Cc: Linus Walleij <linus.walleij@linaro.org> > >> > Cc: Alexandre Courbot <gnurou@gmail.com> > >> > Cc: Jiri Kosina <jkosina@suse.cz> > >> > Cc: linux-input@vger.kernel.org > >> > Cc: linux-gpio@vger.kernel.org > >> > > >> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > > I guess this depends on some other patch that hasn't gone to Linus yet, > > right? As Linus' tree currently has this prototype: > > > > int gpiochip_remove(struct gpio_chip *chip) > > Yes. It is yet to make it to linus's tree. But the change is there in > linux-next master branch. Alright. It probably makes most sense to take this patch together with the prototype change in one pile (i.e. not through my tree). For that purpose Acked-by: Jiri Kosina <jkosina@suse.cz>
On Wednesday 01 October 2014 01:31 PM, Jiri Kosina wrote: > On Wed, 1 Oct 2014, Pramod Gurav wrote: > >>>>> Cc: Linus Walleij <linus.walleij@linaro.org> >>>>> Cc: Alexandre Courbot <gnurou@gmail.com> >>>>> Cc: Jiri Kosina <jkosina@suse.cz> >>>>> Cc: linux-input@vger.kernel.org >>>>> Cc: linux-gpio@vger.kernel.org >>>>> >>>>> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> >>> I guess this depends on some other patch that hasn't gone to Linus yet, >>> right? As Linus' tree currently has this prototype: >>> >>> int gpiochip_remove(struct gpio_chip *chip) >> >> Yes. It is yet to make it to linus's tree. But the change is there in >> linux-next master branch. > > Alright. It probably makes most sense to take this patch together with the > prototype change in one pile (i.e. not through my tree). > > For that purpose > > Acked-by: Jiri Kosina <jkosina@suse.cz> Jiri, Just realized when Linus told me these changes are already in his tree as well as in mast of linux-tree. Sorry for spaming and late realizing this. > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index a822db5..3318de6 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -1069,8 +1069,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) return ret; err_gpiochip_remove: - if (gpiochip_remove(&dev->gc) < 0) - hid_err(hdev, "error removing gpio chip\n"); + gpiochip_remove(&dev->gc); err_free_i2c: i2c_del_adapter(&dev->adap); err_free_dev: @@ -1089,8 +1088,7 @@ static void cp2112_remove(struct hid_device *hdev) struct cp2112_device *dev = hid_get_drvdata(hdev); sysfs_remove_group(&hdev->dev.kobj, &cp2112_attr_group); - if (gpiochip_remove(&dev->gc)) - hid_err(hdev, "unable to remove gpio chip\n"); + gpiochip_remove(&dev->gc); i2c_del_adapter(&dev->adap); /* i2c_del_adapter has finished removing all i2c devices from our * adapter. Well behaved devices should no longer call our cp2112_xfer
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Jiri Kosina <jkosina@suse.cz> Cc: linux-input@vger.kernel.org Cc: linux-gpio@vger.kernel.org Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> --- drivers/hid/hid-cp2112.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)