| Message ID | C80EF34A3D2E494DBAF9AC29C7AE4EB80A1D1498@exchtp03.taipei.via.com.tw |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On 10/15/2009 03:10 AM, JosephChan@via.com.tw wrote: > Just remove redundant device ID for VT8261. > > Signed-off-by: Joseph Chan<josephchan@via.com.tw> > > --- a/drivers/ata/sata_via.c 2009-10-15 21:38:14.000000000 +0800 > +++ b/drivers/ata/sata_via.c 2009-10-15 21:38:28.000000000 +0800 > @@ -93,7 +93,6 @@ > { PCI_VDEVICE(VIA, 0x7372), vt6420 }, > { PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */ > { PCI_VDEVICE(VIA, 0x9000), vt8251 }, > - { PCI_VDEVICE(VIA, 0x9040), vt8251 }, PCI device ID 0x9040 does not exist elsewhere in the driver... how is it redundant? Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
JosephChan@via.com.tw wrote: > Just remove redundant device ID for VT8261. > > Signed-off-by: Joseph Chan <josephchan@via.com.tw> Looks okay to me. > --- a/drivers/ata/sata_via.c 2009-10-15 21:38:14.000000000 +0800 > +++ b/drivers/ata/sata_via.c 2009-10-15 21:38:28.000000000 +0800 > @@ -93,7 +93,6 @@ > { PCI_VDEVICE(VIA, 0x7372), vt6420 }, > { PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */ > { PCI_VDEVICE(VIA, 0x9000), vt8251 }, > - { PCI_VDEVICE(VIA, 0x9040), vt8251 }, > > { } /* terminate list */ > }; > > N�����r��y���b�X��ǧv�^�){.n�+����{��ע��^n�r��z���h����&�� �G���h�(�階�ݢj"���m�����z�ޖ���f���h���~�mml== But, what's the above garbled line?
PiBQQ0kgZGV2aWNlIElEIDB4OTA0MCBkb2VzIG5vdCBleGlzdCBlbHNld2hlcmUgaW4gdGhlIGRy aXZlci4uLiAgaG93IGlzIGl0IHJlZHVuZGFudD8NCg0KMS4gU28gZmFyLCB0aGVyZSBpcyBubyBW VDgyNjEgc2lsaWNvbiBpbiB0aGUgcHVibGljIG1hcmtldC4NCjIuIERldmljZSBJRCAweDkwMDAg YW5kIDB4OTA0MCBhcmUgcmVkdW5kYW50IChmb3IgVlQ4MjYxKS4gVGhlIDB4OTA0MCBpcyByZXNl cnZlZCBmb3Igb3RoZXIgdXNhZ2UuDQoNCkJScywNCkpvc2VwaA0KDQoNCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/15/2009 03:19 AM, Tejun Heo wrote: > JosephChan@via.com.tw wrote: >> Just remove redundant device ID for VT8261. >> >> Signed-off-by: Joseph Chan<josephchan@via.com.tw> > > Looks okay to me. > >> --- a/drivers/ata/sata_via.c 2009-10-15 21:38:14.000000000 +0800 >> +++ b/drivers/ata/sata_via.c 2009-10-15 21:38:28.000000000 +0800 >> @@ -93,7 +93,6 @@ >> { PCI_VDEVICE(VIA, 0x7372), vt6420 }, >> { PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */ >> { PCI_VDEVICE(VIA, 0x9000), vt8251 }, >> - { PCI_VDEVICE(VIA, 0x9040), vt8251 }, >> >> { } /* terminate list */ >> }; >> >> N�����r��y���b�X��ǧv�^�){.n�+����{��ע��^n�r��z���h����&�� �G���h�(�階�ݢj"���m�����z�ޖ���f���h���~�mml== > > But, what's the above garbled line? (cc'ing postmaster@vger) It is interesting that Joseph's email directly to me was OK, but the copy passing through vger.kernel.org list software included this garbled line. Joseph's email was base64-encoded, and vger just got new mailing list software in the past year or so... so I wonder if this is a vger bug? Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DQo+PiAgQnV0LCB3aGF0J3MgdGhlIGFib3ZlIGdhcmJsZWQgbGluZT8NCg0KPiBKb3NlcGgncyBl bWFpbCB3YXMgYmFzZTY0LWVuY29kZWQsIGFuZCB2Z2VyIGp1c3QgZ290IG5ldyBtYWlsaW5nIGxp c3QgDQo+IHNvZnR3YXJlIGluIHRoZSBwYXN0IHllYXIgb3Igc28uLi4gICBzbyBJIHdvbmRlciBp ZiB0aGlzIGlzIGEgdmdlciBidWc/DQoNClNvcnJ5LCBpdCBzaG91bGQgYmUgbXkgZWRpdG9yJ3Mg YnVnLg0KSSBjb3BpZWQgdGhlIHBhdGNoIHdpdGggYW4gZXh0cmEgYmxhbmsgbGluZS4gQW5kIGl0 IGNhdXNlZCB0aGUgZ3JhYmxlZCBsaW5lIHlvdSBzYXcuIA0KSSB3aWxsIHJlc2VuZCB0aGlzIHBh dGNoIGxhdGVyIGlmIHRoZXJlIGlzIG5vIHByb2JsZW0gZm9yIHRoaXMgcGF0Y2guIDopDQoNCkJS cywNCkpvc2VwaCBDaGFuIA0K -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jeff Garzik <jeff@garzik.org> Date: Thu, 15 Oct 2009 03:36:10 -0400 > Joseph's email was base64-encoded, and vger just got new mailing list > software in the past year or so... so I wonder if this is a vger bug? vger hasn't had new mailing list software in 10 years :-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/15/2009 11:37 AM, David Miller wrote: > From: Jeff Garzik<jeff@garzik.org> > Date: Thu, 15 Oct 2009 03:36:10 -0400 > >> Joseph's email was base64-encoded, and vger just got new mailing list >> software in the past year or so... so I wonder if this is a vger bug? > > vger hasn't had new mailing list software in 10 years :-) I thought Matti was working on something new, but I guess I was mistaken. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jeff Garzik <jeff@garzik.org> Date: Thu, 15 Oct 2009 11:46:54 -0400 > On 10/15/2009 11:37 AM, David Miller wrote: >> From: Jeff Garzik<jeff@garzik.org> >> Date: Thu, 15 Oct 2009 03:36:10 -0400 >> >>> Joseph's email was base64-encoded, and vger just got new mailing list >>> software in the past year or so... so I wonder if this is a vger bug? >> >> vger hasn't had new mailing list software in 10 years :-) > > I thought Matti was working on something new, but I guess I was > mistaken. Yes, but as far as I am aware it isn't live yet. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/ata/sata_via.c 2009-10-15 21:38:14.000000000 +0800 +++ b/drivers/ata/sata_via.c 2009-10-15 21:38:28.000000000 +0800 @@ -93,7 +93,6 @@ { PCI_VDEVICE(VIA, 0x7372), vt6420 }, { PCI_VDEVICE(VIA, 0x5287), vt8251 }, /* 2 sata chnls (Master/Slave) */ { PCI_VDEVICE(VIA, 0x9000), vt8251 }, - { PCI_VDEVICE(VIA, 0x9040), vt8251 }, { } /* terminate list */ };
Just remove redundant device ID for VT8261. Signed-off-by: Joseph Chan <josephchan@via.com.tw>