| Message ID | CAC+sh-dSpNLcdwkJA_J+XPFCxmMibgcAbof71o2eQ2pK5O2b-A@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Sep 10, 2014 at 10:21:23PM +0200, Tim Lammens wrote: > Hi, > > Here is a patch to fix the memory leak in libio/wfileops.c. Thanks, I'll push this fix. Your submission is lacking a ChangeLog, but I'll write it up for you. If you're looking to contribute more regularly, you might want to review the contribution checklist[1]. Siddhesh [1] https://sourceware.org/glibc/wiki/Contribution%20checklist > > Regards, > Tim > > > diff --git a/libio/wfileops.c b/libio/wfileops.c > index f123add..4b8fda9 100644 > --- a/libio/wfileops.c > +++ b/libio/wfileops.c > @@ -711,6 +711,7 @@ do_ftell_wide (_IO_FILE *fp) > return WEOF; > > offset += outstop - out; > + free(out); > } > > /* We don't trust _IO_read_end to represent the current file offset
Great! My apologies, I didn't see the checklist in time. Regards, Tim On Thu, Sep 11, 2014 at 1:05 AM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote: > On Wed, Sep 10, 2014 at 10:21:23PM +0200, Tim Lammens wrote: >> Hi, >> >> Here is a patch to fix the memory leak in libio/wfileops.c. > > Thanks, I'll push this fix. Your submission is lacking a ChangeLog, > but I'll write it up for you. If you're looking to contribute more > regularly, you might want to review the contribution checklist[1]. > > Siddhesh > > [1] https://sourceware.org/glibc/wiki/Contribution%20checklist > >> >> Regards, >> Tim >> >> >> diff --git a/libio/wfileops.c b/libio/wfileops.c >> index f123add..4b8fda9 100644 >> --- a/libio/wfileops.c >> +++ b/libio/wfileops.c >> @@ -711,6 +711,7 @@ do_ftell_wide (_IO_FILE *fp) >> return WEOF; >> >> offset += outstop - out; >> + free(out); >> } >> >> /* We don't trust _IO_read_end to represent the current file offset
On 11/09/14 09:05, Siddhesh Poyarekar wrote: > On Wed, Sep 10, 2014 at 10:21:23PM +0200, Tim Lammens wrote: >> Hi, >> >> Here is a patch to fix the memory leak in libio/wfileops.c. > > Thanks, I'll push this fix. Your submission is lacking a ChangeLog, > but I'll write it up for you. If you're looking to contribute more > regularly, you might want to review the contribution checklist[1]. > > Siddhesh > > [1] https://sourceware.org/glibc/wiki/Contribution%20checklist > Do we also need to free this in the error case directly above? >> >> >> diff --git a/libio/wfileops.c b/libio/wfileops.c >> index f123add..4b8fda9 100644 >> --- a/libio/wfileops.c >> +++ b/libio/wfileops.c >> @@ -711,6 +711,7 @@ do_ftell_wide (_IO_FILE *fp) >> return WEOF; >> >> offset += outstop - out; >> + free(out); >> } >> >> /* We don't trust _IO_read_end to represent the current file offset
diff --git a/libio/wfileops.c b/libio/wfileops.c index f123add..4b8fda9 100644 --- a/libio/wfileops.c +++ b/libio/wfileops.c @@ -711,6 +711,7 @@ do_ftell_wide (_IO_FILE *fp) return WEOF; offset += outstop - out; + free(out); } /* We don't trust _IO_read_end to represent the current file offset