Message ID | 4AC36638.8070304@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote: > prev_vlan_tag field is not used. > > Patch saves 512*8 bytes per tx queue ring on 64bit arches. > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Looks good to me. Acked-by: Matthew Carlson <mcarlson@broadcom.com> > --- > > diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h > index 82b45d8..524691c 100644 > --- a/drivers/net/tg3.h > +++ b/drivers/net/tg3.h > @@ -2412,7 +2412,6 @@ struct ring_info { > > struct tx_ring_info { > struct sk_buff *skb; > - u32 prev_vlan_tag; > }; > > struct tg3_config_info { > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Matt Carlson" <mcarlson@broadcom.com> Date: Wed, 30 Sep 2009 10:26:43 -0700 > On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote: >> prev_vlan_tag field is not used. >> >> Patch saves 512*8 bytes per tx queue ring on 64bit arches. >> >> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > > Looks good to me. > > Acked-by: Matthew Carlson <mcarlson@broadcom.com> Applied, thanks. Eric, I had to apply this by hand because: >> @@ -2412,7 +2412,6 @@ struct ring_info { >> >> struct tx_ring_info { >> struct sk_buff *skb; >> - u32 prev_vlan_tag; >> }; Your email client changed tabs into spaces. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller a écrit : > > Applied, thanks. > > Eric, I had to apply this by hand because: > >>> @@ -2412,7 +2412,6 @@ struct ring_info { >>> >>> struct tx_ring_info { >>> struct sk_buff *skb; >>> - u32 prev_vlan_tag; >>> }; > > Your email client changed tabs into spaces. Oops, I'm sorry Dave, I did a copy/paste and forgot about tabs. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h index 82b45d8..524691c 100644 --- a/drivers/net/tg3.h +++ b/drivers/net/tg3.h @@ -2412,7 +2412,6 @@ struct ring_info { struct tx_ring_info { struct sk_buff *skb; - u32 prev_vlan_tag; }; struct tg3_config_info {
prev_vlan_tag field is not used. Patch saves 512*8 bytes per tx queue ring on 64bit arches. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html