| Message ID | 1403181112-12018-1-git-send-email-linux@rasmusvillemoes.dk |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
From: Rasmus Villemoes <linux@rasmusvillemoes.dk> Date: Thu, 19 Jun 2014 14:31:52 +0200 > Flipping a bit doesn't need four lines of code; and gcc seems to > actually generate two branches. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Applied to sparc-next -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index 7c71e7b..3221dff 100644 --- a/drivers/sbus/char/display7seg.c +++ b/drivers/sbus/char/display7seg.c @@ -143,10 +143,7 @@ static long d7s_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case D7SIOCTM: /* toggle device mode-- flip display orientation */ - if (regs & D7S_FLIP) - regs &= ~D7S_FLIP; - else - regs |= D7S_FLIP; + regs ^= D7S_FLIP; writeb(regs, p->regs); break; }
Flipping a bit doesn't need four lines of code; and gcc seems to actually generate two branches. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/sbus/char/display7seg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)