| Message ID | alpine.LFD.2.00.0909110543410.11692@localhost |
|---|---|
| State | New, archived |
| Headers | show |
>>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes: Robert> Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> Robert> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in Robert> drivers/mtd/devices/Kconfig. Robert> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
On Fri, 2009-09-11 at 05:44 -0400, Robert P. J. Day wrote: > Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> > CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in > drivers/mtd/devices/Kconfig. > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Actually, a patch you sent earlier is already in the mtd-2.6.git tree: http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc
On Mon, 14 Sep 2009, Artem Bityutskiy wrote: > On Fri, 2009-09-11 at 05:44 -0400, Robert P. J. Day wrote: > > Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> > > CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in > > drivers/mtd/devices/Kconfig. > > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > Actually, a patch you sent earlier is already in the mtd-2.6.git tree: > http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc i submitted a different one based on the recommendation of what should be changed for those two bits of text to match up. either one of those two patches will work just fine, they just resolve the issue in opposite ways. whatever people on this list prefer is fine with me. rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index 43976aa..70a7369 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len, (void) dataflash_waitready(priv->spi); -#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE +#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY /* (3) Compare to Buffer1 */ addr = pageaddr << priv->page_offset; @@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len, } else status = 0; -#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */ +#endif /* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */ remaining = remaining - writelen; pageaddr++;
Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in drivers/mtd/devices/Kconfig. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- whoops, sorry, previous commit msg didn't show the actual correction, this one does. ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================