| Message ID | alpine.LFD.2.00.0909100716440.19313@localhost |
|---|---|
| State | New, archived |
| Headers | show |
>>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes:
Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so
Robert> that it matches the spelling here:
Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
Robert> -config MTD_DATAFLASH_WRITE_VERIFY
Robert> +config MTD_DATAFLASH_VERIFY_WRITE
It probably makes more sense to change the .c file instead of Kconfig,
to not bother/confuse people and simply make it "just work".
On Thu, 10 Sep 2009, Peter Korsgaard wrote: > >>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes: > > Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so > Robert> that it matches the spelling here: > > Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE > Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */ > > Robert> -config MTD_DATAFLASH_WRITE_VERIFY > Robert> +config MTD_DATAFLASH_VERIFY_WRITE > > It probably makes more sense to change the .c file instead of Kconfig, > to not bother/confuse people and simply make it "just work". ok, if that's the consensus, i'll have that patch out later today. rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================
diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig index 325fab9..3265e96 100644 --- a/drivers/mtd/devices/Kconfig +++ b/drivers/mtd/devices/Kconfig @@ -59,7 +59,7 @@ config MTD_DATAFLASH Sometimes DataFlash chips are packaged inside MMC-format cards; at this writing, the MMC stack won't handle those. -config MTD_DATAFLASH_WRITE_VERIFY +config MTD_DATAFLASH_VERIFY_WRITE bool "Verify DataFlash page writes" depends on MTD_DATAFLASH help
Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so that it matches the spelling here: drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */ Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================