| Message ID | 1401881559-18469-4-git-send-email-mperttunen@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 06/04/2014 05:32 AM, Mikko Perttunen wrote: > This enables the integrated SATA controller on the Tegra124 system-on-chip > on the Jetson TK1 board and adds regulators for the onboard Molex connector > commonly used to power SATA devices. The regulators are marked always-on > since they can be used for other purposes than powering SATA devices. > diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > + sata@0,70020000 { > + target-supply = <&vdd_5v0_sata>; regulators { > + /* Molex power connector */ > + vdd_5v0_sata: regulator@13 { > + compatible = "regulator-fixed"; > + reg = <13>; > + regulator-name = "+5V_SATA"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpio TEGRA_GPIO(EE, 2) GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <&vdd_5v0_sys>; > + regulator-always-on; > + }; Why is this always-on, considering that the SATA node references this, and presumably the driver explicitly enables this regulator? > + > + vdd_12v0_sata: regulator@14 { > + compatible = "regulator-fixed"; > + reg = <14>; > + regulator-name = "+12V_SATA"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + gpio = <&gpio TEGRA_GPIO(EE, 2) GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <&vdd_mux>; > + regulator-always-on; > + }; > }; If there are two regulators required for the SATA devices, shouldn't the SATA node's target-supply property reference them both? Well, I suppose there'd need to be target-5v-supply and target-12v-supply properties, since each regulator property can only reference a single supply, IIRC. I think the DT binding needs to be updated for this. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts index 38d3087..33a062c 100644 --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts @@ -1686,6 +1686,17 @@ vbus-supply = <&vdd_usb3_vbus>; }; + /* Serial ATA */ + sata@0,70020000 { + status = "okay"; + + hvdd-supply = <&vdd_3v3_lp0>; + vddio-supply = <&vdd_1v05_run>; + avdd-supply = <&vdd_1v05_run>; + + target-supply = <&vdd_5v0_sata>; + }; + clocks { compatible = "simple-bus"; #address-cells = <1>; @@ -1827,6 +1838,31 @@ enable-active-high; vin-supply = <&vdd_5v0_sys>; }; + + /* Molex power connector */ + vdd_5v0_sata: regulator@13 { + compatible = "regulator-fixed"; + reg = <13>; + regulator-name = "+5V_SATA"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio TEGRA_GPIO(EE, 2) GPIO_ACTIVE_HIGH>; + enable-active-high; + vin-supply = <&vdd_5v0_sys>; + regulator-always-on; + }; + + vdd_12v0_sata: regulator@14 { + compatible = "regulator-fixed"; + reg = <14>; + regulator-name = "+12V_SATA"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + gpio = <&gpio TEGRA_GPIO(EE, 2) GPIO_ACTIVE_HIGH>; + enable-active-high; + vin-supply = <&vdd_mux>; + regulator-always-on; + }; }; sound {
This enables the integrated SATA controller on the Tegra124 system-on-chip on the Jetson TK1 board and adds regulators for the onboard Molex connector commonly used to power SATA devices. The regulators are marked always-on since they can be used for other purposes than powering SATA devices. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Cc: devicetree@vger.kernel.org --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 36 +++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+)