| Message ID | 1401185980-29536-1-git-send-email-Ying.Liu@freescale.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi, Liu Ying wrote: > This patch contains no logic change to cleanup indentation > for register definitions only. > > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawn.guo@freescale.com> > Cc: Lothar Waßmann <LW@KARO-electronics.de> > Cc: linux-pwm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > drivers/pwm/pwm-imx.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c > index cc47733..0784554 100644 > --- a/drivers/pwm/pwm-imx.c > +++ b/drivers/pwm/pwm-imx.c > @@ -21,24 +21,24 @@ > > /* i.MX1 and i.MX21 share the same PWM function block: */ > > -#define MX1_PWMC 0x00 /* PWM Control Register */ > -#define MX1_PWMS 0x04 /* PWM Sample Register */ > -#define MX1_PWMP 0x08 /* PWM Period Register */ > +#define MX1_PWMC 0x00 /* PWM Control Register */ > +#define MX1_PWMS 0x04 /* PWM Sample Register */ > +#define MX1_PWMP 0x08 /* PWM Period Register */ > > -#define MX1_PWMC_EN (1 << 4) > +#define MX1_PWMC_EN (1 << 4) > > /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */ > > -#define MX3_PWMCR 0x00 /* PWM Control Register */ > -#define MX3_PWMSAR 0x0C /* PWM Sample Register */ > -#define MX3_PWMPR 0x10 /* PWM Period Register */ > -#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) > -#define MX3_PWMCR_DOZEEN (1 << 24) > -#define MX3_PWMCR_WAITEN (1 << 23) > +#define MX3_PWMCR 0x00 /* PWM Control Register */ > +#define MX3_PWMSAR 0x0C /* PWM Sample Register */ > +#define MX3_PWMPR 0x10 /* PWM Period Register */ > +#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) ^ You could also add the missing () around the macro argument when you are changing this line anyway. Lothar Waßmann
On 05/28/2014 05:56 PM, Lothar Waßmann wrote: > Hi, > > Liu Ying wrote: >> This patch contains no logic change to cleanup indentation >> for register definitions only. >> >> Cc: Thierry Reding <thierry.reding@gmail.com> >> Cc: Sascha Hauer <s.hauer@pengutronix.de> >> Cc: Shawn Guo <shawn.guo@freescale.com> >> Cc: Lothar Waßmann <LW@KARO-electronics.de> >> Cc: linux-pwm@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> --- >> drivers/pwm/pwm-imx.c | 26 +++++++++++++------------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c >> index cc47733..0784554 100644 >> --- a/drivers/pwm/pwm-imx.c >> +++ b/drivers/pwm/pwm-imx.c >> @@ -21,24 +21,24 @@ >> >> /* i.MX1 and i.MX21 share the same PWM function block: */ >> >> -#define MX1_PWMC 0x00 /* PWM Control Register */ >> -#define MX1_PWMS 0x04 /* PWM Sample Register */ >> -#define MX1_PWMP 0x08 /* PWM Period Register */ >> +#define MX1_PWMC 0x00 /* PWM Control Register */ >> +#define MX1_PWMS 0x04 /* PWM Sample Register */ >> +#define MX1_PWMP 0x08 /* PWM Period Register */ >> >> -#define MX1_PWMC_EN (1 << 4) >> +#define MX1_PWMC_EN (1 << 4) >> >> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */ >> >> -#define MX3_PWMCR 0x00 /* PWM Control Register */ >> -#define MX3_PWMSAR 0x0C /* PWM Sample Register */ >> -#define MX3_PWMPR 0x10 /* PWM Period Register */ >> -#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) >> -#define MX3_PWMCR_DOZEEN (1 << 24) >> -#define MX3_PWMCR_WAITEN (1 << 23) >> +#define MX3_PWMCR 0x00 /* PWM Control Register */ >> +#define MX3_PWMSAR 0x0C /* PWM Sample Register */ >> +#define MX3_PWMPR 0x10 /* PWM Period Register */ >> +#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) > ^ > You could also add the missing () around the macro argument when you > are changing this line anyway. > I may generate a separate patch to do that. Thanks. > > Lothar Waßmann >
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index cc47733..0784554 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -21,24 +21,24 @@ /* i.MX1 and i.MX21 share the same PWM function block: */ -#define MX1_PWMC 0x00 /* PWM Control Register */ -#define MX1_PWMS 0x04 /* PWM Sample Register */ -#define MX1_PWMP 0x08 /* PWM Period Register */ +#define MX1_PWMC 0x00 /* PWM Control Register */ +#define MX1_PWMS 0x04 /* PWM Sample Register */ +#define MX1_PWMP 0x08 /* PWM Period Register */ -#define MX1_PWMC_EN (1 << 4) +#define MX1_PWMC_EN (1 << 4) /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */ -#define MX3_PWMCR 0x00 /* PWM Control Register */ -#define MX3_PWMSAR 0x0C /* PWM Sample Register */ -#define MX3_PWMPR 0x10 /* PWM Period Register */ -#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) -#define MX3_PWMCR_DOZEEN (1 << 24) -#define MX3_PWMCR_WAITEN (1 << 23) +#define MX3_PWMCR 0x00 /* PWM Control Register */ +#define MX3_PWMSAR 0x0C /* PWM Sample Register */ +#define MX3_PWMPR 0x10 /* PWM Period Register */ +#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) +#define MX3_PWMCR_DOZEEN (1 << 24) +#define MX3_PWMCR_WAITEN (1 << 23) #define MX3_PWMCR_DBGEN (1 << 22) -#define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16) -#define MX3_PWMCR_CLKSRC_IPG (1 << 16) -#define MX3_PWMCR_EN (1 << 0) +#define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16) +#define MX3_PWMCR_CLKSRC_IPG (1 << 16) +#define MX3_PWMCR_EN (1 << 0) struct imx_chip { struct clk *clk_per;
This patch contains no logic change to cleanup indentation for register definitions only. Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Shawn Guo <shawn.guo@freescale.com> Cc: Lothar Waßmann <LW@KARO-electronics.de> Cc: linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- drivers/pwm/pwm-imx.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)