Message ID | 1394283554-27423-1-git-send-email-r.peniaev@gmail.com |
---|---|
State | Accepted |
Commit | 566c0d6a74169dc5cc9f353ff4a8d579d96a85ff |
Headers | show |
On Sat, Mar 08, 2014 at 09:59:14PM +0900, Roman Pen wrote: > From: Roman Peniaev <r.peniaev@gmail.com> > > mtd_blkdevs is device with volatile cache (writeback buffer), so it should support > REQ_FLUSH to do explicit flush. > > Without this patch 'sync' does not guarantee that writeback buffer will be flushed > on disk in case of power off, e.g.: > > $ cp some_file /mnt > $ sync > > ### POWER OFF > > In case of this sequence writeback buffer will not be flushed on disk. > > This patch fixes this behaviour and explicitly reports to block layer that flush > requests are being supported. > > Signed-off-by: Roman Peniaev <r.peniaev@gmail.com> > CC: David Woodhouse <dwmw2@infradead.org> > CC: Brian Norris <computersforpeace@gmail.com> > CC: linux-mtd@lists.infradead.org > CC: linux-kernel@vger.kernel.org Pushed to l2-mtd.git. Thanks! Brian
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 5073cbc..b2970a0 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -89,6 +89,9 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr, if (req->cmd_type != REQ_TYPE_FS) return -EIO; + if (req->cmd_flags & REQ_FLUSH) + return tr->flush(dev); + if (blk_rq_pos(req) + blk_rq_cur_sectors(req) > get_capacity(req->rq_disk)) return -EIO; @@ -409,6 +412,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) if (!new->rq) goto error3; + if (tr->flush) + blk_queue_flush(new->rq, REQ_FLUSH); + new->rq->queuedata = new; blk_queue_logical_block_size(new->rq, tr->blksize);