diff mbox

[committed] Skip gcc.dg/torture/pr60092.c on 32-bit hpux

Message ID BLU0-SMTP87780544A0C561E8250BFE977A0@phx.gbl
State New
Headers show

Commit Message

John David Anglin March 24, 2014, 12:50 a.m. UTC 
The test fails because there is no undefined weak support on 32-bit  
hpux.

Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
Committed to trunk.

Dave
--
John David Anglin	dave.anglin@bell.net
2014-03-23  John David Anglin  <danglin@gcc.gnu.org>

	* gcc.dg/torture/pr60092.c: Skip on 32-bit hpux.

Comments

Rainer Orth March 24, 2014, 6:45 a.m. UTC | #1 
John David Anglin <dave.anglin@bell.net> writes:

> Index: gcc.dg/torture/pr60092.c
> ===================================================================
> --- gcc.dg/torture/pr60092.c	(revision 208769)
> +++ gcc.dg/torture/pr60092.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* { dg-do run } */
>  /* { dg-require-weak "" } */
> +/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } { "*" } { "" } } */

Please omit those default args to dg-skip-if.  Besides, it seems we
should have a separate undefined_weak (or whatever) keyword for this,
rather than listing targets explicitly.  But that's certainly not 4.9
material.

	Rainer
John David Anglin March 24, 2014, 2:02 p.m. UTC | #2 
On 3/24/2014 2:45 AM, Rainer Orth wrote:
> John David Anglin <dave.anglin@bell.net> writes:
>
>> Index: gcc.dg/torture/pr60092.c
>> ===================================================================
>> --- gcc.dg/torture/pr60092.c	(revision 208769)
>> +++ gcc.dg/torture/pr60092.c	(working copy)
>> @@ -1,5 +1,6 @@
>>   /* { dg-do run } */
>>   /* { dg-require-weak "" } */
>> +/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } { "*" } { "" } } */
> Please omit those default args to dg-skip-if.  Besides, it seems we
> should have a separate undefined_weak (or whatever) keyword for this,
> rather than listing targets explicitly.  But that's certainly not 4.9
> material.
I agree.  I'll see about removing the default arguments.  There are a 
bunch of  tests
with the same dg-skip-if statement.

Dave
Rainer Orth March 24, 2014, 2:06 p.m. UTC | #3 
John David Anglin <dave.anglin@bell.net> writes:

> On 3/24/2014 2:45 AM, Rainer Orth wrote:
>> John David Anglin <dave.anglin@bell.net> writes:
>>
>>> Index: gcc.dg/torture/pr60092.c
>>> ===================================================================
>>> --- gcc.dg/torture/pr60092.c	(revision 208769)
>>> +++ gcc.dg/torture/pr60092.c	(working copy)
>>> @@ -1,5 +1,6 @@
>>>   /* { dg-do run } */
>>>   /* { dg-require-weak "" } */
>>> +/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } {
>>> "*" } { "" } } */
>> Please omit those default args to dg-skip-if.  Besides, it seems we
>> should have a separate undefined_weak (or whatever) keyword for this,
>> rather than listing targets explicitly.  But that's certainly not 4.9
>> material.
> I agree.  I'll see about removing the default arguments.  There are a bunch
> of  tests

Thanks.

> with the same dg-skip-if statement.

I know.  I mean to make a pass over the whole testsuite removing those
(now superfluous) default args.  This stuff tends to be just copied
around, so it will resurface over and over again.  Same for other stuff:
our testsuite is riddled with copy-and-paste programming ;-)

	Rainer
diff mbox

Patch

Index: gcc.dg/torture/pr60092.c
===================================================================
--- gcc.dg/torture/pr60092.c	(revision 208769)
+++ gcc.dg/torture/pr60092.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-weak "" } */
+/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } { "*" } { "" } } */
 /* { dg-xfail-run-if "posix_memalign modifies first arg on error" { *-*-solaris2.11* } { "-O0" } } */
 
 typedef __SIZE_TYPE__ size_t;