diff mbox

Set correct probability for ORDER/UNORDER jumps

Message ID CAO2gOZV8DiimCQ+dRT9a9bU3ZTzvcHp4A81kHpgQBJNpGjRkRg@mail.gmail.com
State New
Headers show

Commit Message

Dehao Chen Jan. 24, 2014, 9:54 p.m. UTC 
Thanks, test updated:


On Fri, Jan 24, 2014 at 11:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jan 24, 2014 at 10:57 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Fri, Jan 24, 2014 at 10:20:53AM -0800, Dehao Chen wrote:
>>> --- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>> +++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>> @@ -0,0 +1,12 @@
>>> +/* { dg-do compile { target { x86_64-*-* } } } */
>>
>> If you want it for x86_64 64-bit, then
>> /* { dg-do compile { target { { i?86-*-* x86_64-*-* } && lp64 } } } */
>>
>
> It should be "! { ia32 }" instead of "lp64" unless it doesn't work
> for x32.
>
> --
> H.J.

Comments

Dehao Chen Feb. 10, 2014, 4:35 p.m. UTC | #1 
ping...

Dehao

On Fri, Jan 24, 2014 at 1:54 PM, Dehao Chen <dehao@google.com> wrote:
> Thanks, test updated:
>
> Index: gcc/testsuite/gcc.dg/predict-8.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
> +++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
> @@ -0,0 +1,12 @@
> +/* { dg-do compile { target { i?86-*-* x86_64-*-* } } } */
> +/* { dg-options "-O2 -fdump-rtl-expand" } */
> +
> +int foo(float a, float b) {
> +  if (a == b)
> +    return 1;
> +  else
> +    return 2;
> +}
> +
> +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 100" 1 "expand"} } */
> +/* { dg-final { cleanup-rtl-dump "expand" } } */
>
> On Fri, Jan 24, 2014 at 11:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Fri, Jan 24, 2014 at 10:57 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>> On Fri, Jan 24, 2014 at 10:20:53AM -0800, Dehao Chen wrote:
>>>> --- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>>> +++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>>> @@ -0,0 +1,12 @@
>>>> +/* { dg-do compile { target { x86_64-*-* } } } */
>>>
>>> If you want it for x86_64 64-bit, then
>>> /* { dg-do compile { target { { i?86-*-* x86_64-*-* } && lp64 } } } */
>>>
>>
>> It should be "! { ia32 }" instead of "lp64" unless it doesn't work
>> for x32.
>>
>> --
>> H.J.
Dehao Chen March 21, 2014, 9:13 p.m. UTC | #2 
ping ^2...

Dehao

On Mon, Feb 10, 2014 at 8:35 AM, Dehao Chen <dehao@google.com> wrote:
> ping...
>
> Dehao
>
> On Fri, Jan 24, 2014 at 1:54 PM, Dehao Chen <dehao@google.com> wrote:
>> Thanks, test updated:
>>
>> Index: gcc/testsuite/gcc.dg/predict-8.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>> +++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>> @@ -0,0 +1,12 @@
>> +/* { dg-do compile { target { i?86-*-* x86_64-*-* } } } */
>> +/* { dg-options "-O2 -fdump-rtl-expand" } */
>> +
>> +int foo(float a, float b) {
>> +  if (a == b)
>> +    return 1;
>> +  else
>> +    return 2;
>> +}
>> +
>> +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 100" 1 "expand"} } */
>> +/* { dg-final { cleanup-rtl-dump "expand" } } */
>>
>> On Fri, Jan 24, 2014 at 11:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Jan 24, 2014 at 10:57 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>>> On Fri, Jan 24, 2014 at 10:20:53AM -0800, Dehao Chen wrote:
>>>>> --- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>>>> +++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
>>>>> @@ -0,0 +1,12 @@
>>>>> +/* { dg-do compile { target { x86_64-*-* } } } */
>>>>
>>>> If you want it for x86_64 64-bit, then
>>>> /* { dg-do compile { target { { i?86-*-* x86_64-*-* } && lp64 } } } */
>>>>
>>>
>>> It should be "! { ia32 }" instead of "lp64" unless it doesn't work
>>> for x32.
>>>
>>> --
>>> H.J.
Steven Bosscher March 21, 2014, 11:08 p.m. UTC | #3 
On Fri, Mar 21, 2014 at 10:13 PM, Dehao Chen <dehao@google.com> wrote:
> ping ^2...


Assuming this concerns
http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01460.html and
follow-ups.
OK.

Ciao!
Steven
diff mbox

Patch

Index: gcc/testsuite/gcc.dg/predict-8.c
===================================================================
--- gcc/testsuite/gcc.dg/predict-8.c (revision 0)
+++ gcc/testsuite/gcc.dg/predict-8.c (revision 0)
@@ -0,0 +1,12 @@ 
+/* { dg-do compile { target { i?86-*-* x86_64-*-* } } } */
+/* { dg-options "-O2 -fdump-rtl-expand" } */
+
+int foo(float a, float b) {
+  if (a == b)
+    return 1;
+  else
+    return 2;
+}
+
+/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 100" 1 "expand"} } */
+/* { dg-final { cleanup-rtl-dump "expand" } } */