| Message ID | 645960637.5604340.1393616238164.JavaMail.zimbra@inria.fr |
|---|---|
| State | New |
| Headers | show |
On Fri, Feb 28, 2014 at 8:37 PM, Mircea Namolaru <mircea.namolaru@inria.fr> wrote: > Hi, > > Thanks. Here is the updated patch. Boostrapped / tested on x86_64-unknown-linux-gnu and applied. Thanks, Richard. > 2014-02-26 Tobias Grosser <tobias@grosser.es> > Mircea Namolaru <mircea.namolaru@inria.fr> > > PR tree-optimization/58028 > * graphite-clast-to-gimple.c (set_cloog_options): Don't remove scalar > dimensions. > > Index: gcc/graphite-clast-to-gimple.c > =================================================================== > --- gcc/graphite-clast-to-gimple.c (revision 207298) > +++ gcc/graphite-clast-to-gimple.c (working copy) > @@ -1522,6 +1522,13 @@ > variables. */ > options->save_domains = 1; > > + /* Do not remove scalar dimensions. CLooG by default removes scalar > + dimensions very early from the input schedule. However, they are > + necessary to correctly derive from the saved domains > + (options->save_domains) the relationship between the generated loops > + and the schedule dimensions they are generated from. */ > + options->noscalars = 1; > + > /* Disable optimizations and make cloog generate source code closer to the > input. This is useful for debugging, but later we want the optimized > code. > > Mircea
On 03/03/2014 12:39 PM, Richard Biener wrote: > On Fri, Feb 28, 2014 at 8:37 PM, Mircea Namolaru > <mircea.namolaru@inria.fr> wrote: >> Hi, >> >> Thanks. Here is the updated patch. > > Boostrapped / tested on x86_64-unknown-linux-gnu and applied. Thanks Richard! Tobias
Index: gcc/graphite-clast-to-gimple.c =================================================================== --- gcc/graphite-clast-to-gimple.c (revision 207298) +++ gcc/graphite-clast-to-gimple.c (working copy) @@ -1522,6 +1522,13 @@ variables. */ options->save_domains = 1; + /* Do not remove scalar dimensions. CLooG by default removes scalar + dimensions very early from the input schedule. However, they are + necessary to correctly derive from the saved domains + (options->save_domains) the relationship between the generated loops + and the schedule dimensions they are generated from. */ + options->noscalars = 1; + /* Disable optimizations and make cloog generate source code closer to the input. This is useful for debugging, but later we want the optimized code.
Hi, Thanks. Here is the updated patch. 2014-02-26 Tobias Grosser <tobias@grosser.es> Mircea Namolaru <mircea.namolaru@inria.fr> PR tree-optimization/58028 * graphite-clast-to-gimple.c (set_cloog_options): Don't remove scalar dimensions. Mircea