diff mbox

Documentation: broadcom-bcmgenet: fix address and cells properties

Message ID 1392683255-28136-1-git-send-email-f.fainelli@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Florian Fainelli Feb. 18, 2014, 12:27 a.m. UTC
This patch fixes a typo in the Device Tree binding for the
leading '#'.

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Florian Fainelli Feb. 18, 2014, 4:37 a.m. UTC | #1
Le lundi 17 février 2014, 16:27:35 Florian Fainelli a écrit :
> This patch fixes a typo in the Device Tree binding for the
> leading '#'.
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---

Forgot to mention that this patch is for the net-next tree. Thanks!

>  Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt index
> 88c3d04..25339ee 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> @@ -10,8 +10,8 @@ Required properties:
>  - phy-mode: String, operation mode of the PHY interface. Supported values
> are "mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR
> "phy-connection-type" values
> -- address-cells: should be 1
> -- size-cells: should be 1
> +- #address-cells: should be 1
> +- #size-cells: should be 1
> 
>  Optional properties:
>  - clocks: When provided, must be two phandles to the functional clocks
> nodes @@ -42,8 +42,8 @@ MDIO bus node required properties:
>    parent node compatible property (e.g: brcm,genet-v4 pairs with
>    brcm,genet-mdio-v4)
>  - reg: address and length relative to the parent node base register address
> -- address-cells: address cell for MDIO bus addressing, should be 1 --
> size-cells: size of the cells for MDIO bus addressing, should be 0 +-
> #address-cells: address cell for MDIO bus addressing, should be 1 +-
> #size-cells: size of the cells for MDIO bus addressing, should be 0
> 
>  Ethernet PHY node properties:
David Miller Feb. 18, 2014, 10:23 p.m. UTC | #2
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 17 Feb 2014 16:27:35 -0800

> This patch fixes a typo in the Device Tree binding for the
> leading '#'.
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Sergei put the phy-mode documentation to a common location, so you'll
need to respin this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
index 88c3d04..25339ee 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
+++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
@@ -10,8 +10,8 @@  Required properties:
 - phy-mode: String, operation mode of the PHY interface. Supported values are
   "mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR
   "phy-connection-type" values
-- address-cells: should be 1
-- size-cells: should be 1
+- #address-cells: should be 1
+- #size-cells: should be 1
 
 Optional properties:
 - clocks: When provided, must be two phandles to the functional clocks nodes
@@ -42,8 +42,8 @@  MDIO bus node required properties:
   parent node compatible property (e.g: brcm,genet-v4 pairs with
   brcm,genet-mdio-v4)
 - reg: address and length relative to the parent node base register address
-- address-cells: address cell for MDIO bus addressing, should be 1
-- size-cells: size of the cells for MDIO bus addressing, should be 0
+- #address-cells: address cell for MDIO bus addressing, should be 1
+- #size-cells: size of the cells for MDIO bus addressing, should be 0
 
 Ethernet PHY node properties: