diff mbox

[U-Boot] relocate-rela: replace a magic number with sizeof(Elf64_Rela)

Message ID 1391479111-31498-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Albert ARIBAUD
Headers show

Commit Message

Masahiro Yamada Feb. 4, 2014, 1:58 a.m. UTC 
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Scott Wood <scottwood@freescale.com>
Cc: David Feng <fenghua@phytium.com.cn>
---
 tools/relocate-rela.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Scott Wood Feb. 4, 2014, 2 a.m. UTC | #1 
On Tue, 2014-02-04 at 10:58 +0900, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> ---
>  tools/relocate-rela.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
> index 93b4c39..670b9fd 100644
> --- a/tools/relocate-rela.c
> +++ b/tools/relocate-rela.c
> @@ -120,7 +120,7 @@ int main(int argc, char **argv)
>  	}
>  
>  	if (rela_start > rela_end || rela_start < text_base ||
> -	    (rela_end - rela_start) % 24) {
> +	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
>  		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
>  		return 3;
>  	}

Acked-by: Scott Wood <scottwood@freescale.com>

-Scott
Albert ARIBAUD Feb. 13, 2014, 2:19 p.m. UTC | #2 
Hi Masahiro,

On Tue,  4 Feb 2014 10:58:31 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> ---
>  tools/relocate-rela.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
> index 93b4c39..670b9fd 100644
> --- a/tools/relocate-rela.c
> +++ b/tools/relocate-rela.c
> @@ -120,7 +120,7 @@ int main(int argc, char **argv)
>  	}
>  
>  	if (rela_start > rela_end || rela_start < text_base ||
> -	    (rela_end - rela_start) % 24) {
> +	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
>  		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
>  		return 3;
>  	}

Applied to u-boot-arm/master, thanks!

Amicalement,
diff mbox

Patch

diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
index 93b4c39..670b9fd 100644
--- a/tools/relocate-rela.c
+++ b/tools/relocate-rela.c
@@ -120,7 +120,7 @@  int main(int argc, char **argv)
 	}
 
 	if (rela_start > rela_end || rela_start < text_base ||
-	    (rela_end - rela_start) % 24) {
+	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
 		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
 		return 3;
 	}