| Message ID | 1389277919-15279-1-git-send-email-m.zalega@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Looks good to me. CC'd mmc Custodian. Acked-by: Jaehoon Chung <jh80.chung@samsung.com> On 01/09/2014 11:31 PM, Mateusz Zalega wrote: > Structure definition used type block_dev_desc_t, defined in part.h, which > wasn't included in mmc.h. It worked only in circumstances when common.h, > or another header using part.h was incuded in implementation files. > > Change-Id: I3ccf56ce1e5334c32a7bc061e8bd9a5054ccb7f5 > Signed-off-by: Mateusz Zalega <m.zalega@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > --- > include/mmc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/mmc.h b/include/mmc.h > index cb558da..e490a06 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -12,6 +12,7 @@ > > #include <linux/list.h> > #include <linux/compiler.h> > +#include <part.h> > > #define SD_VERSION_SD 0x20000 > #define SD_VERSION_3 (SD_VERSION_SD | 0x300) >
This is an updated version of patch series regarding DFU, MMC, USB Gadget and Samsung Goni board, originally sent on 10 January 2014. --- Changes since v1: - reordered "USB: gadget: added a saner gadget downloader registration API" - fixed a bug related to usb_cable_connected() which broke previous Goni configuration patches - disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity --- Mateusz Zalega (12): mmc: mmc header fix part: header fix arm:goni: Update configuration for goni target dfu: fix boards wo USB cable detection am335x: dfu: disable DFU in am335x_evm SPL build USB: gadget: added a saner gadget downloader registration API arm:goni:dfu Add support for DFU to Goni target arm:goni: enable GPT command arm:goni: enable USB Mass Storage dfu:mmc: raw data write fix mmc: postponed needless timer initialization ums: always initialize mmc before ums_disk_init() board/samsung/common/ums.c | 12 ++-- board/samsung/goni/goni.c | 9 +++ common/cmd_dfu.c | 3 +- common/cmd_thordown.c | 3 +- common/cmd_usb_mass_storage.c | 4 +- drivers/dfu/dfu_mmc.c | 106 +++++++++++++++++++-------------- drivers/mmc/mmc.c | 7 ++- drivers/usb/gadget/f_dfu.c | 11 +++- drivers/usb/gadget/f_mass_storage.c | 6 ++ drivers/usb/gadget/f_thor.c | 5 ++ drivers/usb/gadget/g_dnl.c | 74 +++++++++++------------ include/configs/am335x_evm.h | 10 ++-- include/configs/s5p_goni.h | 113 +++++++++++++++++++++++++----------- include/configs/trats.h | 2 +- include/configs/trats2.h | 2 +- include/dfu.h | 12 ---- include/g_dnl.h | 11 ++++ include/mmc.h | 1 + include/part.h | 1 + include/thor.h | 8 --- include/usb_mass_storage.h | 8 --- 21 files changed, 239 insertions(+), 169 deletions(-)
This is an updated version of patch series regarding DFU, MMC, USB Gadget and Samsung Goni board, originally sent on 10 January 2014. --- Changes since v1: - reordered "USB: gadget: added a saner gadget downloader registration API" - fixed a bug related to usb_cable_connected() which broke previous Goni configuration patches - disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity v2: - fixed issues which came to [Marek Vasut]'s attention - rebased --- Mateusz Zalega (13): mmc: mmc header fix part: header fix arm:goni: Update configuration for goni target dfu: fix boards wo USB cable detection am335x: dfu: disable DFU in am335x_evm SPL build USB: gadget: added a saner gadget downloader registration API arm:goni:dfu Add support for DFU to Goni target arm:goni: enable GPT command arm:goni: enable USB Mass Storage dfu:mmc: raw data write fix mmc: postponed needless timer initialization ums: always initialize mmc before ums_disk_init() common: fixed linker-list example board/samsung/common/ums.c | 12 ++-- board/samsung/goni/goni.c | 8 +++ common/cmd_dfu.c | 3 +- common/cmd_thordown.c | 3 +- common/cmd_usb_mass_storage.c | 4 +- drivers/dfu/dfu_mmc.c | 106 +++++++++++++++++++-------------- drivers/mmc/mmc.c | 7 ++- drivers/usb/gadget/f_dfu.c | 3 + drivers/usb/gadget/f_mass_storage.c | 3 + drivers/usb/gadget/f_thor.c | 2 + drivers/usb/gadget/g_dnl.c | 64 +++++++++----------- include/configs/am335x_evm.h | 10 ++-- include/configs/s5p_goni.h | 113 +++++++++++++++++++++++++----------- include/configs/trats.h | 2 +- include/configs/trats2.h | 2 +- include/dfu.h | 12 ---- include/g_dnl.h | 24 ++++++++ include/linker_lists.h | 2 +- include/mmc.h | 1 + include/part.h | 1 + include/thor.h | 8 --- include/usb_mass_storage.h | 8 --- 22 files changed, 236 insertions(+), 162 deletions(-)
This is, I hope, the final version of patchset. Custodians: please ack appropriate patches. Minkyu Kang: Could you pick it up after it gets reviewed by the community? patches 1-7: fixes that can be applied before features patches 8-13: features and fixes that depend on features Patchset has been tested by running MAKEALL -a arm on every commit, so that it wouldn't break bisect. Cc: Minkyu Kang <mk7.kang@samsung.com> Cc: Marek Vasut <marex@denx.de> Cc: Tom Rini <trini@ti.com> Cc: Lukasz Majewski <l.majewski@samsung.com> Cc: Pantelis Antoniou <panto@antoniou-consulting.com> --- Changes since v1: - reordered "USB: gadget: added a saner gadget downloader registration API" - fixed a bug related to usb_cable_connected() which broke previous Goni configuration patches - disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity v2: - fixed issues which came to [Marek Vasut]'s attention - rebased v3: - previous version of the ums patch introduced "unused variable" warnings - const attribute of function argument broke existing interface in one of MMC patches - grouped patches related to common topics --- Mateusz Zalega (13): mmc: mmc header fix part: header fix common: fixed linker-list example usb: dfu: fix boards wo USB cable detection mmc: postponed needless timer initialization dfu: mmc: raw data write fix ums: always initialize mmc before ums_disk_init() am335x: dfu: disable DFU in am335x_evm SPL build USB: gadget: added a saner gadget downloader registration API arm: goni: Update configuration for Goni target arm: goni: dfu: Add support for DFU to Goni target arm: goni: enable GPT command arm: goni: enable USB Mass Storage board/samsung/common/ums.c | 10 ++-- board/samsung/goni/goni.c | 8 +++ common/cmd_dfu.c | 3 +- common/cmd_thordown.c | 3 +- common/cmd_usb_mass_storage.c | 4 +- drivers/dfu/dfu_mmc.c | 106 +++++++++++++++++++-------------- drivers/mmc/mmc.c | 7 ++- drivers/usb/gadget/f_dfu.c | 3 + drivers/usb/gadget/f_mass_storage.c | 3 + drivers/usb/gadget/f_thor.c | 2 + drivers/usb/gadget/g_dnl.c | 64 +++++++++----------- include/configs/am335x_evm.h | 10 ++-- include/configs/s5p_goni.h | 113 +++++++++++++++++++++++++----------- include/configs/trats.h | 2 +- include/configs/trats2.h | 2 +- include/dfu.h | 12 ---- include/g_dnl.h | 24 ++++++++ include/linker_lists.h | 2 +- include/mmc.h | 1 + include/part.h | 1 + include/thor.h | 8 --- include/usb_mass_storage.h | 8 --- 22 files changed, 235 insertions(+), 161 deletions(-)
Patchset contains fixes for: * DFU write issues * USB cable detection * ums command * U-Boot's base framework (headers) * fixed base DFU offsets and features: * convenient USB Gadget registration * Samsung Goni DFU, UMS, GPT bringup also: * am335x will no longer support DFU in SPL builds There _are_ dependencies between these patches. ie. Goni stuff depends on the new Gadget registration API, which in turn depends on disabling DFU in am335x's SPL build so that some poor soul wouldn't trip over a board-breaking commit while running git bisect, and I could have not written correct code without fixing u-boot headers first... Cc: Minkyu Kang <mk7.kang@samsung.com> Cc: Lukasz Majewski <l.majewski@samsung.com> Cc: Tom Rini <trini@ti.com> Cc: Marek Vasut <marex@denx.de> --- Changes since v1: - reordered "USB: gadget: added a saner gadget downloader registration API" - fixed a bug related to usb_cable_connected() which broke previous Goni configuration patches - disabled DFU in TI's am335x SPL build due to insufficient ROM capacity since v2: in "USB: gadget: added a saner gadget downloader": fixed issues which came to [Marek Vasut]'s attention: - fixed coding style issues - added convenient macro wrappers for used ll_entry_declare since v3: - grouped patches related to common topics in "ums: always initialize mmc before ums_disk_init()" - Added const attribute of ums_disk_init introduced type warnings. It would take a lot of changes to MMC core code to fix it, so it was dropped, even though ums_disk_init shouldn't and doesn't change struct mmc it is passed. since v4: - added detailed changelog to each patch - removed patches which can go in separately: "common: fixed linker-list example" "mmc: postponed needless timer initialization" in "dfu: mmc: raw data write fix": - commit message was made more detailed - the patch was split in two, introducing "dfu: mmc: change offset base handling" to the patchset in "usb: dfu: fix boards wo USB cable detection": - removed CONFIG_USB_CABLE_CHECK - moved implementation from usb.h (reserved for USB host code) to USB gadget - renamed usb_cable_connected to g_dnl_usb_cable_connected - removed defunct board implementations (origen, universal) - added __weak default implementation and removed ifdef'd blocks around dependent code in "gadget: added a saner gadget downloader" - fixed coding style issues reported by [Jaehoon Chung] --- Mateusz Zalega (12): mmc: mmc header fix part: header fix usb: dfu: fix boards wo USB cable detection dfu: mmc: raw data write fix dfu: mmc: change offset base handling ums: always initialize mmc before ums_disk_init() am335x: dfu: disable DFU in am335x_evm SPL build USB: gadget: added a saner gadget downloader registration API arm: goni: Update configuration for Goni target arm: goni: dfu: Add support for DFU to Goni target arm: goni: enable GPT command arm: goni: enable USB Mass Storage README | 7 -- board/samsung/common/ums.c | 6 +- board/samsung/goni/goni.c | 8 +++ board/samsung/origen/origen.c | 7 -- board/samsung/trats/trats.c | 4 +- board/samsung/trats2/trats2.c | 4 +- board/samsung/universal_c210/universal.c | 7 -- common/cmd_dfu.c | 3 +- common/cmd_thordown.c | 3 +- common/cmd_usb_mass_storage.c | 10 ++- drivers/dfu/dfu_mmc.c | 109 ++++++++++++++++++----------- drivers/usb/gadget/f_dfu.c | 3 + drivers/usb/gadget/f_mass_storage.c | 11 +-- drivers/usb/gadget/f_thor.c | 2 + drivers/usb/gadget/g_dnl.c | 69 +++++++++---------- include/configs/am335x_evm.h | 10 +-- include/configs/exynos4-dt.h | 1 - include/configs/s5p_goni.h | 113 +++++++++++++++++++++---------- include/configs/trats.h | 2 +- include/configs/trats2.h | 2 +- include/dfu.h | 12 ---- include/g_dnl.h | 24 +++++++ include/mmc.h | 1 + include/part.h | 1 + include/thor.h | 8 --- include/usb.h | 10 --- include/usb_mass_storage.h | 8 --- 27 files changed, 247 insertions(+), 198 deletions(-)
diff --git a/include/mmc.h b/include/mmc.h index cb558da..e490a06 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -12,6 +12,7 @@ #include <linux/list.h> #include <linux/compiler.h> +#include <part.h> #define SD_VERSION_SD 0x20000 #define SD_VERSION_3 (SD_VERSION_SD | 0x300)
Structure definition used type block_dev_desc_t, defined in part.h, which wasn't included in mmc.h. It worked only in circumstances when common.h, or another header using part.h was incuded in implementation files. Change-Id: I3ccf56ce1e5334c32a7bc061e8bd9a5054ccb7f5 Signed-off-by: Mateusz Zalega <m.zalega@samsung.com> Cc: Minkyu Kang <mk7.kang@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> --- include/mmc.h | 1 + 1 file changed, 1 insertion(+)