Message ID | 1391093726-7569-1-git-send-email-ludovic.desroches@atmel.com |
---|---|
State | Rejected |
Headers | show |
>>>>> <ludovic.desroches@atmel.com> writes: > From: Ludovic Desroches <ludovic.desroches@atmel.com> > Defconfig file for boards based on sama5d3x devices. > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com> > --- > Hi, > This is a basic defconf file for sama5d3 devices. at91boostrap, u-boot, linux > stuff will come later. Thanks, but we prefer our defconfigs to just be the minimal needed to configure buildroot for the hardware (arch/variant, bootloader, kernel) - E.G. something like configs/nitrogen6x_defconfig Care to send such a minimal defconfig with comments instead? >> From the top of my head Alexandre Belloni told me that some flags have to be > added for hardware floating point use. It was on a previous version when > hard floating has been introduced. Is it still true or does selecting EABIHF is > enough? Selecting EABIHF should afaik be enough.
Hi Peter, On Tue, Feb 04, 2014 at 10:06:13AM +0100, Peter Korsgaard wrote: > >>>>> <ludovic.desroches@atmel.com> writes: > > > From: Ludovic Desroches <ludovic.desroches@atmel.com> > > Defconfig file for boards based on sama5d3x devices. > > > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com> > > --- > > > Hi, > > > This is a basic defconf file for sama5d3 devices. at91boostrap, u-boot, linux > > stuff will come later. > > Thanks, but we prefer our defconfigs to just be the minimal needed to > configure buildroot for the hardware (arch/variant, bootloader, kernel) > - E.G. something like configs/nitrogen6x_defconfig Ok > > Care to send such a minimal defconfig with comments instead? Sorry, not sure to have understood, you mean I have to put extra packages I want as comments. > > >> From the top of my head Alexandre Belloni told me that some flags have to be > > added for hardware floating point use. It was on a previous version when > > hard floating has been introduced. Is it still true or does selecting EABIHF is > > enough? > > Selecting EABIHF should afaik be enough. > > -- > Bye, Peter Korsgaard Regards Ludovic
>>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@atmel.com> writes: >> Care to send such a minimal defconfig with comments instead? > Sorry, not sure to have understood, you mean I have to put extra packages I > want as comments. No, please take a look at our other defconfigs (E.G. nitrogen6x): # architecture BR2_arm=y BR2_cortex_a9=y # system BR2_TARGET_GENERIC_GETTY=y BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" BR2_ROOTFS_POST_BUILD_SCRIPT="board/boundarydevices/nitrogen6x/post-build.sh" # filesystem BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_2r1=y # bootloader BR2_TARGET_UBOOT=y BR2_TARGET_UBOOT_BOARDNAME="nitrogen6q" BR2_TARGET_UBOOT_FORMAT_IMX=y BR2_TARGET_UBOOT_CUSTOM_TARBALL=y BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="http://github.com/boundarydevices/u-boot-imx6/tarball/4034391/u-boot-4034391.tar.gz" # kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_TARBALL=y BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="http://github.com/boundarydevices/linux-imx6/tarball/5809938/linux-imx6-5809938.tar.gz" BR2_LINUX_KERNEL_DEFCONFIG="nitrogen6x" BR2_LINUX_KERNEL_INSTALL_TARGET=y It doesn't enable any usecase specific packages, just the needed arch/getty/linux/bootloader configuration to start working from.
On Tue, Feb 04, 2014 at 01:47:33PM +0100, Peter Korsgaard wrote: > >>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@atmel.com> writes: > > >> Care to send such a minimal defconfig with comments instead? > > > Sorry, not sure to have understood, you mean I have to put extra packages I > > want as comments. > > No, please take a look at our other defconfigs (E.G. nitrogen6x): I had a look but I didn't understand what you mean by comments. So ok, those kind of comments. > > # architecture > BR2_arm=y > BR2_cortex_a9=y > > # system > BR2_TARGET_GENERIC_GETTY=y > BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" > BR2_ROOTFS_POST_BUILD_SCRIPT="board/boundarydevices/nitrogen6x/post-build.sh" > > # filesystem > BR2_TARGET_ROOTFS_EXT2=y > BR2_TARGET_ROOTFS_EXT2_2r1=y > > # bootloader > BR2_TARGET_UBOOT=y > BR2_TARGET_UBOOT_BOARDNAME="nitrogen6q" > BR2_TARGET_UBOOT_FORMAT_IMX=y > BR2_TARGET_UBOOT_CUSTOM_TARBALL=y > BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="http://github.com/boundarydevices/u-boot-imx6/tarball/4034391/u-boot-4034391.tar.gz" > > # kernel > BR2_LINUX_KERNEL=y > BR2_LINUX_KERNEL_CUSTOM_TARBALL=y > BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="http://github.com/boundarydevices/linux-imx6/tarball/5809938/linux-imx6-5809938.tar.gz" > BR2_LINUX_KERNEL_DEFCONFIG="nitrogen6x" > BR2_LINUX_KERNEL_INSTALL_TARGET=y > > > It doesn't enable any usecase specific packages, just the needed > arch/getty/linux/bootloader configuration to start working from. > I understand this point of view and I am fine with it. But my concern is that some customers want something working out of the box. For instance, we often use devmem2 for debugging purpose or other tools such as i2c-tools. It is easier for us to have it in a defconfig file. I am not trying to convince you to take this defconfig as is! Just to know if there is a way to provide specific packages? If not, it will be provided only in our buildroot-at91 repository. I am also fine with this, if the customer wants something out of the box then he'll have to use our repository. Otherwise he could use buildroot one. Regards Ludovic
>>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@atmel.com> writes: Hi, > I understand this point of view and I am fine with it. But my concern > is that some customers want something working out of the box. For > instance, we often use devmem2 for debugging purpose or other tools > such as i2c-tools. It is easier for us to have it in a defconfig > file. > I am not trying to convince you to take this defconfig as is! Just to > know if there is a way to provide specific packages? If not, it will > be provided only in our buildroot-at91 repository. I am also fine > with this, if the customer wants something out of the box then he'll > have to use our repository. Otherwise he could use buildroot one. I understand. We're been discussing something like this a few times (E.G. full blown "demo" defconfigs), but for now I prefer to keep the variant in buildroot minimal.
On 04/02/14 15:24, Peter Korsgaard wrote: >>>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@atmel.com> writes: > > Hi, > > > I understand this point of view and I am fine with it. But my concern > > is that some customers want something working out of the box. For > > instance, we often use devmem2 for debugging purpose or other tools > > such as i2c-tools. It is easier for us to have it in a defconfig > > file. > > > I am not trying to convince you to take this defconfig as is! Just to > > know if there is a way to provide specific packages? If not, it will > > be provided only in our buildroot-at91 repository. I am also fine > > with this, if the customer wants something out of the box then he'll > > have to use our repository. Otherwise he could use buildroot one. > > I understand. We're been discussing something like this a few times > (E.G. full blown "demo" defconfigs), but for now I prefer to keep the > variant in buildroot minimal. However, we are OK with a minimal and a demo variant. So you can submit one patch that builds a minimal config in configs/sama5d3_defconfig, and a second patch that adds a demo defconfig in configs/sama5d3_demo_multimedia_defconfig (it looks like you mainly add multimedia packages, hence the name I chose, but you can take something else of course). Regards, Arnout
On Tue, Feb 04, 2014 at 05:54:13PM +0100, Arnout Vandecappelle wrote: > On 04/02/14 15:24, Peter Korsgaard wrote: > >>>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@atmel.com> writes: > > > > Hi, > > > > > I understand this point of view and I am fine with it. But my concern > > > is that some customers want something working out of the box. For > > > instance, we often use devmem2 for debugging purpose or other tools > > > such as i2c-tools. It is easier for us to have it in a defconfig > > > file. > > > > > I am not trying to convince you to take this defconfig as is! Just to > > > know if there is a way to provide specific packages? If not, it will > > > be provided only in our buildroot-at91 repository. I am also fine > > > with this, if the customer wants something out of the box then he'll > > > have to use our repository. Otherwise he could use buildroot one. > > > > I understand. We're been discussing something like this a few times > > (E.G. full blown "demo" defconfigs), but for now I prefer to keep the > > variant in buildroot minimal. > > However, we are OK with a minimal and a demo variant. So you can submit > one patch that builds a minimal config in configs/sama5d3_defconfig, and > a second patch that adds a demo defconfig in > configs/sama5d3_demo_multimedia_defconfig (it looks like you mainly add > multimedia packages, hence the name I chose, but you can take something > else of course). > Once other components would be ready, I'll send a minimal defconfig and a demo defconfig then I let you choose if you want to take both or not. Regards Ludovic
Ludovic, On Thu, 30 Jan 2014 15:55:26 +0100, ludovic.desroches@atmel.com wrote: > From: Ludovic Desroches <ludovic.desroches@atmel.com> > > Defconfig file for boards based on sama5d3x devices. > > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com> Since you posted your patch, we have merged a defconfig for the SAMA5D3 Xplained board that matches the "requirements" of Buildroot in terms of defconfig. See http://git.buildroot.net/buildroot/commit/?id=54a653f649d131f8a038fc1314383b60294ad351. So I'll mark your patch as Rejected in our patch tracking system. Of course, feel free to send a new patch if you disagree with this decision. Thanks, Thomas Petazzoni
diff --git a/configs/sama5d3_defconfig b/configs/sama5d3_defconfig new file mode 100644 index 0000000..d54e76d --- /dev/null +++ b/configs/sama5d3_defconfig @@ -0,0 +1,104 @@ +BR2_arm=y +BR2_cortex_a5=y +BR2_ARM_EABIHF=y +BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_INSTRUCTIONS_THUMB2=y +BR2_TOOLCHAIN_EXTERNAL=y +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV=y +BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-1.20.x.config" +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y +BR2_PACKAGE_ALSA_UTILS=y +BR2_PACKAGE_ALSA_UTILS_ALSACONF=y +BR2_PACKAGE_ALSA_UTILS_AMIXER=y +BR2_PACKAGE_ALSA_UTILS_APLAY=y +BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y +BR2_PACKAGE_FFMPEG=y +BR2_PACKAGE_FFMPEG_GPL=y +BR2_PACKAGE_FFMPEG_NONFREE=y +BR2_PACKAGE_FFMPEG_POSTPROC=y +BR2_PACKAGE_GSTREAMER=y +BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_VIDEORATE=y +BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA=y +BR2_PACKAGE_GST_PLUGINS_GOOD=y +BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG=y +BR2_PACKAGE_GST_PLUGINS_GOOD_PNG=y +BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_VIDEOFILTER=y +BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_V4L2=y +BR2_PACKAGE_GST_PLUGINS_BAD=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_COLORSPACE=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_MPEGDEMUX=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_VIDEOFILTERS=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DIRECTFB=y +BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_FBDEV=y +BR2_PACKAGE_GST_PLUGINS_UGLY=y +BR2_PACKAGE_GST_PLUGINS_UGLY_PLUGIN_MPEG2DEC=y +BR2_PACKAGE_GST_FFMPEG=y +BR2_PACKAGE_MPG123=y +BR2_PACKAGE_MPLAYER=y +BR2_PACKAGE_BZIP2=y +BR2_PACKAGE_GZIP=y +BR2_PACKAGE_XZ=y +BR2_PACKAGE_MEMSTAT=y +BR2_PACKAGE_NETPERF=y +BR2_PACKAGE_STRACE=y +BR2_PACKAGE_TAR=y +BR2_PACKAGE_MTD=y +BR2_PACKAGE_MTD_FLASH_OTP_DUMP=y +BR2_PACKAGE_MTD_FLASH_OTP_INFO=y +BR2_PACKAGE_MTD_MKFSJFFS2=y +BR2_PACKAGE_FBV=y +BR2_PACKAGE_QT=y +BR2_PACKAGE_DEVMEM2=y +BR2_PACKAGE_EEPROG=y +BR2_PACKAGE_EVTEST=y +BR2_PACKAGE_I2C_TOOLS=y +BR2_PACKAGE_IOSTAT=y +BR2_PACKAGE_LM_SENSORS=y +BR2_PACKAGE_RNG_TOOLS=y +BR2_PACKAGE_SETSERIAL=y +BR2_PACKAGE_STATSERIAL=y +BR2_PACKAGE_USBUTILS=y +BR2_PACKAGE_USBUTILS_ZLIB=y +BR2_PACKAGE_PYTHON=y +BR2_PACKAGE_PYTHON_CURSES=y +BR2_PACKAGE_PYTHON_READLINE=y +BR2_PACKAGE_PYTHON_NETIFACES=y +BR2_PACKAGE_PYTHON_SERIAL=y +BR2_PACKAGE_PYTHON_SETUPTOOLS=y +BR2_PACKAGE_SQLITE=y +BR2_PACKAGE_ZXING=y +BR2_PACKAGE_ARGP_STANDALONE=y +BR2_PACKAGE_BRIDGE_UTILS=y +BR2_PACKAGE_CAN_UTILS=y +BR2_PACKAGE_DROPBEAR=y +BR2_PACKAGE_EBTABLES=y +BR2_PACKAGE_ETHTOOL=y +BR2_PACKAGE_IPERF=y +BR2_PACKAGE_IPROUTE2=y +BR2_PACKAGE_IPTABLES=y +BR2_PACKAGE_IW=y +BR2_PACKAGE_LRZSZ=y +BR2_PACKAGE_MACCHANGER=y +BR2_PACKAGE_MII_DIAG=y +BR2_PACKAGE_OPENSSH=y +BR2_PACKAGE_PORTMAP=y +BR2_PACKAGE_TCPDUMP=y +BR2_PACKAGE_WIRELESS_TOOLS=y +BR2_PACKAGE_WPA_SUPPLICANT=y +BR2_PACKAGE_WPA_SUPPLICANT_EAP=y +BR2_PACKAGE_WPA_SUPPLICANT_CLI=y +BR2_PACKAGE_WPA_SUPPLICANT_PASSPHRASE=y +BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT=y +BR2_PACKAGE_WPA_SUPPLICANT_WPS=y +BR2_PACKAGE_BASH=y +BR2_PACKAGE_FILE=y +BR2_PACKAGE_CPULOAD=y +BR2_PACKAGE_VIM=y +BR2_TARGET_ROOTFS_CPIO=y +BR2_TARGET_ROOTFS_JFFS2=y +BR2_TARGET_ROOTFS_JFFS2_NANDFLASH_2K_128K=y +BR2_TARGET_ROOTFS_UBIFS=y +BR2_TARGET_ROOTFS_UBIFS_LEBSIZE=0x1f000 +BR2_TARGET_ROOTFS_UBI=y +BR2_TARGET_ROOTFS_UBI_SUBSIZE=2048