diff mbox

[PULL,v4,01/12] lm32_sys: increase test case name length limit

Message ID 1390246471-25167-2-git-send-email-michael@walle.cc
State New
Headers show

Commit Message

Michael Walle Jan. 20, 2014, 7:34 p.m. UTC 
The new MMU tests use longer names.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 hw/misc/lm32_sys.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Maydell Feb. 1, 2014, 5:39 p.m. UTC | #1 
On 20 January 2014 19:34, Michael Walle <michael@walle.cc> wrote:
> The new MMU tests use longer names.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  hw/misc/lm32_sys.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
> index 9bdb781..8176cdb 100644
> --- a/hw/misc/lm32_sys.c
> +++ b/hw/misc/lm32_sys.c
> @@ -42,7 +42,7 @@ enum {
>      R_MAX
>  };
>
> -#define MAX_TESTNAME_LEN 16
> +#define MAX_TESTNAME_LEN 32
>
>  #define TYPE_LM32_SYS "lm32-sys"
>  #define LM32_SYS(obj) OBJECT_CHECK(LM32SysState, (obj), TYPE_LM32_SYS)
> @@ -80,7 +80,7 @@ static void sys_write(void *opaque, hwaddr addr,
>      case R_PASSFAIL:
>          s->regs[addr] = value;
>          testname = (char *)s->testname;
> -        qemu_log("TC  %-16s %s\n", testname, (value) ? "FAILED" : "OK");
> +        qemu_log("TC  %-32s %s\n", testname, (value) ? "FAILED" : "OK");

You could avoid the duplication of the 32 here by using
    qemu_log("TCG %-*s %s\n", MAX_TESTNAME_LEN, testname, value ?
"FAILED" : "OK");

thanks
-- PMM
diff mbox

Patch

diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
index 9bdb781..8176cdb 100644
--- a/hw/misc/lm32_sys.c
+++ b/hw/misc/lm32_sys.c
@@ -42,7 +42,7 @@  enum {
     R_MAX
 };
 
-#define MAX_TESTNAME_LEN 16
+#define MAX_TESTNAME_LEN 32
 
 #define TYPE_LM32_SYS "lm32-sys"
 #define LM32_SYS(obj) OBJECT_CHECK(LM32SysState, (obj), TYPE_LM32_SYS)
@@ -80,7 +80,7 @@  static void sys_write(void *opaque, hwaddr addr,
     case R_PASSFAIL:
         s->regs[addr] = value;
         testname = (char *)s->testname;
-        qemu_log("TC  %-16s %s\n", testname, (value) ? "FAILED" : "OK");
+        qemu_log("TC  %-32s %s\n", testname, (value) ? "FAILED" : "OK");
         break;
     case R_TESTNAME:
         s->regs[addr] = value;