| Message ID | 20140126104044.GA11387@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > This will help make sure I get Cc'd on patches. You wish... This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment? Kevin > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fb53242..adc5973 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -610,6 +610,7 @@ F: hw/*/*vhost* > > virtio > M: Anthony Liguori <aliguori@amazon.com> > +M: Michael S. Tsirkin <mst@redhat.com> > S: Supported > F: hw/*/virtio* > > -- > MST
On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > This will help make sure I get Cc'd on patches. > > You wish... > > This won't change the actual responsibility, i.e. patches to virtio-blk > are still meant to be merged through the block tree, right? It's just so > you get a chance to comment? The proper way to document that is for us to split out virtio-blk.c and add the block tree git repo URL. Let's avoid informal agreements so that maintainership is clear to everyone from just the ./MAINTAINERS file. Stefan
On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > This will help make sure I get Cc'd on patches. > > You wish... > > This won't change the actual responsibility, i.e. patches to virtio-blk > are still meant to be merged through the block tree, right? It's just so > you get a chance to comment? > > Kevin Right - not different from Anthony really. Well for things completely unrelated to block, like virtio 1.0 support it might make sense to merged them through my tree. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index fb53242..adc5973 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -610,6 +610,7 @@ F: hw/*/*vhost* > > > > virtio > > M: Anthony Liguori <aliguori@amazon.com> > > +M: Michael S. Tsirkin <mst@redhat.com> > > S: Supported > > F: hw/*/virtio* > > > > -- > > MST
On Mon, Jan 27, 2014 at 11:51:05AM +0100, Stefan Hajnoczi wrote: > On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > > This will help make sure I get Cc'd on patches. > > > > You wish... > > > > This won't change the actual responsibility, i.e. patches to virtio-blk > > are still meant to be merged through the block tree, right? It's just so > > you get a chance to comment? > > The proper way to document that is for us to split out virtio-blk.c and > add the block tree git repo URL. Let's avoid informal agreements so > that maintainership is clear to everyone from just the ./MAINTAINERS file. > > Stefan MAINTAINERS is really about getting all the right people Cc'd. Who merges what can't be formalized using regular expressions: it depends on more than which files are changed.
Am 27.01.2014 um 11:53 hat Michael S. Tsirkin geschrieben: > On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > > This will help make sure I get Cc'd on patches. > > > > You wish... > > > > This won't change the actual responsibility, i.e. patches to virtio-blk > > are still meant to be merged through the block tree, right? It's just so > > you get a chance to comment? > > > > Kevin > > Right - not different from Anthony really. > Well for things completely unrelated to block, like virtio 1.0 support > it might make sense to merged them through my tree. Yes, I agree. In that case: Acked-by: Kevin Wolf <kwolf@redhat.com>
diff --git a/MAINTAINERS b/MAINTAINERS index fb53242..adc5973 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -610,6 +610,7 @@ F: hw/*/*vhost* virtio M: Anthony Liguori <aliguori@amazon.com> +M: Michael S. Tsirkin <mst@redhat.com> S: Supported F: hw/*/virtio*
This will help make sure I get Cc'd on patches. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)