diff mbox

[2/8] pci-rcar-gen2: add initial device tree documentation

Message ID 1390754945-28142-3-git-send-email-ben.dooks@codethink.co.uk
State Superseded, archived
Headers show

Commit Message

Ben Dooks Jan. 26, 2014, 4:48 p.m. UTC
Add initial documentation for the pci-rcar-gen2 driver device tree bindings.
This is not yet complete and needs work on the sub-nodes for the PCI bus.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-sh@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: horms+renesas@verge.net.au
---
 .../devicetree/bindings/pci/renessas,pci-r8a7790.txt         | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt

Comments

Geert Uytterhoeven Jan. 26, 2014, 7:09 p.m. UTC | #1
On Sun, Jan 26, 2014 at 5:48 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> + - reg : A list of physical regions to access the device. The first is
> +         the operational registers for the OHCI/EHCI controller and the
> +        second region is for the bridge configuration and control registers.

You may want to add "reg-names" to use named regions, as there
is more than one region.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Dooks Jan. 27, 2014, 12:07 p.m. UTC | #2
On 26/01/14 19:09, Geert Uytterhoeven wrote:
> On Sun, Jan 26, 2014 at 5:48 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> + - reg : A list of physical regions to access the device. The first is
>> +         the operational registers for the OHCI/EHCI controller and the
>> +        second region is for the bridge configuration and control registers.
>
> You may want to add "reg-names" to use named regions, as there
> is more than one region.

I will sort that out, it may require further patching...
Sergei Shtylyov Jan. 27, 2014, 1:31 p.m. UTC | #3
Hello.

On 26-01-2014 23:09, Geert Uytterhoeven wrote:

>> + - reg : A list of physical regions to access the device. The first is
>> +         the operational registers for the OHCI/EHCI controller and the
>> +        second region is for the bridge configuration and control registers.

> You may want to add "reg-names" to use named regions, as there
> is more than one region.

    I've already told Ben he can't claim EHCI/OHCI register ranges at the 
bridge node, so there should be only one "reg" specifier.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Dooks Jan. 27, 2014, 1:33 p.m. UTC | #4
On 27/01/14 13:31, Sergei Shtylyov wrote:
> Hello.
>
> On 26-01-2014 23:09, Geert Uytterhoeven wrote:
>
>>> + - reg : A list of physical regions to access the device. The first is
>>> +         the operational registers for the OHCI/EHCI controller and the
>>> +        second region is for the bridge configuration and control
>>> registers.
>
>> You may want to add "reg-names" to use named regions, as there
>> is more than one region.
>
>     I've already told Ben he can't claim EHCI/OHCI register ranges at
> the bridge node, so there should be only one "reg" specifier.

Well, that's going to take quite a bit of changing the driver as
it already assumes two nodes from the platform device definition.
Sergei Shtylyov Jan. 27, 2014, 6:13 p.m. UTC | #5
Hello.

On 01/27/2014 04:33 PM, Ben Dooks wrote:

>>>> + - reg : A list of physical regions to access the device. The first is
>>>> +         the operational registers for the OHCI/EHCI controller and the
>>>> +        second region is for the bridge configuration and control
>>>> registers.

>>> You may want to add "reg-names" to use named regions, as there
>>> is more than one region.

>>     I've already told Ben he can't claim EHCI/OHCI register ranges at
>> the bridge node, so there should be only one "reg" specifier.

> Well, that's going to take quite a bit of changing the driver as
> it already assumes two nodes from the platform device definition.

    Ah, I failed to realize it's not your mistake, sorry.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt
new file mode 100644
index 0000000..a6fd432
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt
@@ -0,0 +1,12 @@ 
+Renesas internal AHB to PCI bridge
+
+This is the bridge used internally to connect the USB controllers to the
+AHB.
+
+Required properties:
+ - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC
+ - reg : A list of physical regions to access the device. The first is
+         the operational registers for the OHCI/EHCI controller and the
+	 second region is for the bridge configuration and control registers.
+ - interrupts : interrupt for the device
+ - clocks : The reference to the device clock