| Message ID | 1390406848-20964-3-git-send-email-k.kozlowski@samsung.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote: > Add documentation for new bindings for controlling (enable/disable) the > Buck9 Converter by GPIO (BUCK9EN). Your CC list for this is *very* large... > + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled > + by GPIO (valid only for buck9). > + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO > + controlling this regulator (valid only for buck9). > + This property is required when 's5m8767,pmic-ext-control-enable' is specified. In what situation might the GPIO be present but not usable - can't we just use the presence of the GPIO property? Also GPIO properties are supposed to be always "-gpios".
On Wed, 2014-01-22 at 19:49 +0000, Mark Brown wrote: > On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote: > > Add documentation for new bindings for controlling (enable/disable) the > > Buck9 Converter by GPIO (BUCK9EN). > > Your CC list for this is *very* large... Hmmm... The get_maintainers produces such long list for any change in Documentation/devicetree/bindings... I'll stop using it for this. > > > + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled > > + by GPIO (valid only for buck9). > > + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO > > + controlling this regulator (valid only for buck9). > > + This property is required when 's5m8767,pmic-ext-control-enable' is specified. > > In what situation might the GPIO be present but not usable - can't we > just use the presence of the GPIO property? Also GPIO properties are > supposed to be always "-gpios". Remove the "s5m8767,pmic-ext-control-enable" and use only "s5m8767,pmic-ext-control-gpios"? Sure, that makes sense. Thanks for idea. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt index fc6b38f035bd..b52ee77dc4c0 100644 --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt @@ -69,13 +69,18 @@ sub-node should be of the format as listed below. }; }; The above regulator entries are defined in regulator bindings documentation -except op_mode description. +except these properties: - op_mode: describes the different operating modes of the LDO's with power mode change in SOC. The different possible values are, 0 - always off mode 1 - on in normal mode 2 - low power mode 3 - suspend mode + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled + by GPIO (valid only for buck9). + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO + controlling this regulator (valid only for buck9). + This property is required when 's5m8767,pmic-ext-control-enable' is specified. The following are the names of the regulators that the s5m8767 pmic block supports. Note: The 'n' in LDOn and BUCKn represents the LDO or BUCK number @@ -148,5 +153,14 @@ Example: regulator-always-on; regulator-boot-on; }; + + vemmc_reg: BUCK9 { + regulator-name = "VMEM_VDD_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + op_mode = <3>; /* Standby Mode */ + s5m8767,pmic-ext-control-enable; + s5m8767,pmic-ext-control-gpio = <&gpk0 2 0>; + }; }; };
Add documentation for new bindings for controlling (enable/disable) the Buck9 Converter by GPIO (BUCK9EN). Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- .../bindings/regulator/s5m8767-regulator.txt | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)