| Message ID | 1389659437-16406-2-git-send-email-bjorn.andersson@sonymobile.com |
|---|---|
| State | Superseded |
| Headers | show |
Thanks Bjorn, I have prepared second version, but never send it out :-). One thing suggested by Mark was missed in this version. On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > The Qualcomm Universal Peripherial (QUP) wraps I2C mini-core and > provide input and output FIFO's for it. I2C controller can operate > as master with supported bus speeds of 100Kbps and 400Kbps. > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > [bjorn: reformulated part of binding description and cleaned up example] > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > --- > .../devicetree/bindings/i2c/qcom,i2c-qup.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt > new file mode 100644 > index 0000000..a99711b > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt > @@ -0,0 +1,41 @@ > +Qualcomm Universal Peripheral (QUP) I2C controller > + > +Required properties: > + - compatible: Should be "qcom,i2c-qup". > + - reg: Should contain QUP register address and length. > + - interrupts: Should contain I2C interrupt. > + > + - clocks: Should contain the core clock and the AHB clock. + - clocks: a list of phandle + clock-specifier pairs for each entry in + clock-names > + - clock-names: Should be "core" for the core clock and "iface" for the > + AHB clock. > + > + - #address-cells: Should be <1> Address cells for i2c device address > + - #size-cells: Should be <0> as i2c addresses have no size component > + > +Optional properties: > + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, > + default is 100kHz if omitted. > + > +Child nodes should conform to i2c bus binding. > + > +Example: > + > + i2c2: i2c@f9924000 { > + compatible = "qcom,i2c-qup"; > + reg = <0xf9924000 0x1000>; > + interrupts = <0 96 0>; > + > + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; In the light of the latest patches from Stephen, this could be + clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>; Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue 14 Jan 00:57 PST 2014, Ivan T. Ivanov wrote: > > Thanks Bjorn, > > I have prepared second version, but never send it out :-). > One thing suggested by Mark was missed in this version. Yeah, Mattew told me you we're assigned to other things and asked me to send out an update as I had gotten it to work on our boards. I did modify the wording of most of these to match how it is written in the other Qualcomm definitions. @Mark, would you rather have me change this to your suggested wording? > > > On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > [snip] > > + - clocks: Should contain the core clock and the AHB clock. > > + - clocks: a list of phandle + clock-specifier pairs for each entry in > + clock-names > This is in line with how it's written in other drivers, so if the DT maintainers doesn't disagree I would like to keep phandles out of the description. This specific line is a verbatime copy of the msm_serial documentation (same block, different mode)... > > + - clock-names: Should be "core" for the core clock and "iface" for the > > + AHB clock. > > + > > + - #address-cells: Should be <1> Address cells for i2c device address > > + - #size-cells: Should be <0> as i2c addresses have no size component > > + > > +Optional properties: > > + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, > > + default is 100kHz if omitted. > > + > > +Child nodes should conform to i2c bus binding. > > + > > +Example: > > + > > + i2c2: i2c@f9924000 { > > + compatible = "qcom,i2c-qup"; > > + reg = <0xf9924000 0x1000>; > > + interrupts = <0 96 0>; > > + > > + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; > > In the light of the latest patches from Stephen, this could be > > + clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>; Yes, that's exactly what I have in my dts. However as this is just an example I didn't feel it was worth tainting the documentation with all those capital letters ;) So unless DT maintainers disagree I would like to just keep it as an example. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, 2014-01-16 at 15:20 -0800, Bjorn Andersson wrote: > On Tue 14 Jan 00:57 PST 2014, Ivan T. Ivanov wrote: > > > > > Thanks Bjorn, > > > > I have prepared second version, but never send it out :-). > > One thing suggested by Mark was missed in this version. > > Yeah, Mattew told me you we're assigned to other things and asked me to send > out an update as I had gotten it to work on our boards. > > I did modify the wording of most of these to match how it is written in the > other Qualcomm definitions. > > @Mark, would you rather have me change this to your suggested wording? > > > > > > > On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > [snip] > > > + - clocks: Should contain the core clock and the AHB clock. > > > > + - clocks: a list of phandle + clock-specifier pairs for each entry in > > + clock-names > > > > This is in line with how it's written in other drivers, so if the DT > maintainers doesn't disagree I would like to keep phandles out of the > description. This specific line is a verbatime copy of the msm_serial > documentation (same block, different mode)... > > > > + - clock-names: Should be "core" for the core clock and "iface" for the > > > + AHB clock. > > > + > > > + - #address-cells: Should be <1> Address cells for i2c device address > > > + - #size-cells: Should be <0> as i2c addresses have no size component > > > + > > > +Optional properties: > > > + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, > > > + default is 100kHz if omitted. > > > + > > > +Child nodes should conform to i2c bus binding. > > > + > > > +Example: > > > + > > > + i2c2: i2c@f9924000 { > > > + compatible = "qcom,i2c-qup"; > > > + reg = <0xf9924000 0x1000>; > > > + interrupts = <0 96 0>; > > > + > > > + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; > > > > In the light of the latest patches from Stephen, this could be > > > > + clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>; > > Yes, that's exactly what I have in my dts. However as this is just an example > I didn't feel it was worth tainting the documentation with all those capital > letters ;) > So unless DT maintainers disagree I would like to just keep it as an example. Until, we get some meaningful board DTS files for Qualcomm platforms, it is easy for people which will like to test or use drivers to just copy and paste these definitions. Regards, Ivan > > Regards, > Bjorn > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt new file mode 100644 index 0000000..a99711b --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt @@ -0,0 +1,41 @@ +Qualcomm Universal Peripheral (QUP) I2C controller + +Required properties: + - compatible: Should be "qcom,i2c-qup". + - reg: Should contain QUP register address and length. + - interrupts: Should contain I2C interrupt. + + - clocks: Should contain the core clock and the AHB clock. + - clock-names: Should be "core" for the core clock and "iface" for the + AHB clock. + + - #address-cells: Should be <1> Address cells for i2c device address + - #size-cells: Should be <0> as i2c addresses have no size component + +Optional properties: + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, + default is 100kHz if omitted. + +Child nodes should conform to i2c bus binding. + +Example: + + i2c2: i2c@f9924000 { + compatible = "qcom,i2c-qup"; + reg = <0xf9924000 0x1000>; + interrupts = <0 96 0>; + + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; + clock-names = "core", "iface"; + + clock-frequency = <355000>; + + #address-cells = <1>; + #size-cells = <0>; + + dummy@60 { + compatible = "dummy"; + reg = <0x60>; + }; + }; +