| Message ID | 1244644748-24211-25-git-send-email-Geert.Uytterhoeven@sonycom.com |
|---|---|
| State | New |
| Headers | show |
On 06/10/2009 07:38 AM, Geert Uytterhoeven wrote: > probe functions should be __devinit > initialization functions should be __init > > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> > Cc: Geoff Levand <geoffrey.levand@am.sony.com> > --- > drivers/usb/host/ehci-ps3.c | 4 ++-- > drivers/usb/host/ohci-ps3.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
On Wed, 2009-06-10 at 16:38 +0200, Geert Uytterhoeven wrote: > probe functions should be __devinit > initialization functions should be __init Please send to USB maintainers or get an ack from them. Cheers, Ben. > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> > Cc: Geoff Levand <geoffrey.levand@am.sony.com> > --- > drivers/usb/host/ehci-ps3.c | 4 ++-- > drivers/usb/host/ohci-ps3.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c > index bb870b8..3e8844e 100644 > --- a/drivers/usb/host/ehci-ps3.c > +++ b/drivers/usb/host/ehci-ps3.c > @@ -76,7 +76,7 @@ static const struct hc_driver ps3_ehci_hc_driver = { > .port_handed_over = ehci_port_handed_over, > }; > > -static int ps3_ehci_probe(struct ps3_system_bus_device *dev) > +static int __devinit ps3_ehci_probe(struct ps3_system_bus_device *dev) > { > int result; > struct usb_hcd *hcd; > @@ -224,7 +224,7 @@ static int ps3_ehci_remove(struct ps3_system_bus_device *dev) > return 0; > } > > -static int ps3_ehci_driver_register(struct ps3_system_bus_driver *drv) > +static int __init ps3_ehci_driver_register(struct ps3_system_bus_driver *drv) > { > return firmware_has_feature(FW_FEATURE_PS3_LV1) > ? ps3_system_bus_driver_register(drv) > diff --git a/drivers/usb/host/ohci-ps3.c b/drivers/usb/host/ohci-ps3.c > index 1d56259..7009504 100644 > --- a/drivers/usb/host/ohci-ps3.c > +++ b/drivers/usb/host/ohci-ps3.c > @@ -75,7 +75,7 @@ static const struct hc_driver ps3_ohci_hc_driver = { > #endif > }; > > -static int ps3_ohci_probe(struct ps3_system_bus_device *dev) > +static int __devinit ps3_ohci_probe(struct ps3_system_bus_device *dev) > { > int result; > struct usb_hcd *hcd; > @@ -224,7 +224,7 @@ static int ps3_ohci_remove(struct ps3_system_bus_device *dev) > return 0; > } > > -static int ps3_ohci_driver_register(struct ps3_system_bus_driver *drv) > +static int __init ps3_ohci_driver_register(struct ps3_system_bus_driver *drv) > { > return firmware_has_feature(FW_FEATURE_PS3_LV1) > ? ps3_system_bus_driver_register(drv)
diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c index bb870b8..3e8844e 100644 --- a/drivers/usb/host/ehci-ps3.c +++ b/drivers/usb/host/ehci-ps3.c @@ -76,7 +76,7 @@ static const struct hc_driver ps3_ehci_hc_driver = { .port_handed_over = ehci_port_handed_over, }; -static int ps3_ehci_probe(struct ps3_system_bus_device *dev) +static int __devinit ps3_ehci_probe(struct ps3_system_bus_device *dev) { int result; struct usb_hcd *hcd; @@ -224,7 +224,7 @@ static int ps3_ehci_remove(struct ps3_system_bus_device *dev) return 0; } -static int ps3_ehci_driver_register(struct ps3_system_bus_driver *drv) +static int __init ps3_ehci_driver_register(struct ps3_system_bus_driver *drv) { return firmware_has_feature(FW_FEATURE_PS3_LV1) ? ps3_system_bus_driver_register(drv) diff --git a/drivers/usb/host/ohci-ps3.c b/drivers/usb/host/ohci-ps3.c index 1d56259..7009504 100644 --- a/drivers/usb/host/ohci-ps3.c +++ b/drivers/usb/host/ohci-ps3.c @@ -75,7 +75,7 @@ static const struct hc_driver ps3_ohci_hc_driver = { #endif }; -static int ps3_ohci_probe(struct ps3_system_bus_device *dev) +static int __devinit ps3_ohci_probe(struct ps3_system_bus_device *dev) { int result; struct usb_hcd *hcd; @@ -224,7 +224,7 @@ static int ps3_ohci_remove(struct ps3_system_bus_device *dev) return 0; } -static int ps3_ohci_driver_register(struct ps3_system_bus_driver *drv) +static int __init ps3_ohci_driver_register(struct ps3_system_bus_driver *drv) { return firmware_has_feature(FW_FEATURE_PS3_LV1) ? ps3_system_bus_driver_register(drv)
probe functions should be __devinit initialization functions should be __init Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> Cc: Geoff Levand <geoffrey.levand@am.sony.com> --- drivers/usb/host/ehci-ps3.c | 4 ++-- drivers/usb/host/ohci-ps3.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)