Message ID | 525C0CDB.6020305@gmail.com |
---|---|
State | Rejected |
Headers | show |
> --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1737,9 +1737,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) > for (ret = 0; ret < num; ret++) { > dev_dbg(&adap->dev, "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n", > ret, > - ((msgs[ret].flags & I2C_M_RD) ? 'R' : 'W'), > + msgs[ret].flags & I2C_M_RD ? 'R' : 'W', > msgs[ret].addr, msgs[ret].len, > - (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : ""); > + msgs[ret].flags & I2C_M_RECV_LEN ? "+" : ""); Don't spend time changing too much here like the paranthesis. It will probably be removed soon in favour of the tracing approach. > @@ -2120,7 +2120,8 @@ EXPORT_SYMBOL(i2c_smbus_read_byte); > s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value) > { > return i2c_smbus_xfer(client->adapter, client->addr, client->flags, > - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL); > + I2C_SMBUS_WRITE, value, > + I2C_SMBUS_BYTE, NULL); Not worth the change IMO. Just drop this patch.
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 66e38a9..7e95fcd 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -1737,9 +1737,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) for (ret = 0; ret < num; ret++) { dev_dbg(&adap->dev, "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n", ret, - ((msgs[ret].flags & I2C_M_RD) ? 'R' : 'W'), + msgs[ret].flags & I2C_M_RD ? 'R' : 'W', msgs[ret].addr, msgs[ret].len, - (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : ""); + msgs[ret].flags & I2C_M_RECV_LEN ? "+" : ""); } #endif @@ -2120,7 +2120,8 @@ EXPORT_SYMBOL(i2c_smbus_read_byte); s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value) { return i2c_smbus_xfer(client->adapter, client->addr, client->flags, - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL); + I2C_SMBUS_WRITE, value, + I2C_SMBUS_BYTE, NULL); } EXPORT_SYMBOL(i2c_smbus_write_byte);