| Message ID | 1388942528-10453-18-git-send-email-pl@kamp.de |
|---|---|
| State | New |
| Headers | show |
On 2014年01月06日 01:22, Peter Lieven wrote: > reopening is currently not supported. > > Signed-off-by: Peter Lieven <pl@kamp.de> For curiosity, is anything specific to nfs stopping the support of reopen? I think commit will work with host NFS mounted images. Fam
On 06.01.2014 06:51, Fam Zheng wrote: > On 2014年01月06日 01:22, Peter Lieven wrote: >> reopening is currently not supported. >> >> Signed-off-by: Peter Lieven <pl@kamp.de> > > For curiosity, is anything specific to nfs stopping the support of reopen? I think commit will work with host NFS mounted images. The driver has to implement at least .bdrv_reopen_prepare. Peter
diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index 55358ac..2144463 100755 --- a/tests/qemu-iotests/020 +++ b/tests/qemu-iotests/020 @@ -46,6 +46,11 @@ _supported_fmt qcow qcow2 vmdk qed _supported_proto generic _supported_os Linux +# NFS does not support bdrv_reopen_prepare thus qemu-img commit fails. +if [ "$IMGPROTO" = "nfs" ]; then + _notrun "image protocol $IMGPROTO does not support bdrv_commit" +fi + TEST_OFFSETS="0 4294967296" TEST_IMG=$TEST_IMG.base _make_test_img 6G
reopening is currently not supported. Signed-off-by: Peter Lieven <pl@kamp.de> --- tests/qemu-iotests/020 | 5 +++++ 1 file changed, 5 insertions(+)