| Message ID | 20080923141219.GA31262@oksana.dev.rtsoft.ru (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 4c3ed7d61bd474380e0d3e1eb0da164942f7c84e |
| Delegated to: | Kumar Gala |
| Headers | show |
On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote: > of/base.c matches on the first (most specific) entries, which isn't > quite practical but it was discussed[1] that this won't change. > > The bindings specifies verbose information for the devices, but > it doesn't fit in the I2C ID's 20 characters limit. The limit won't > change[2], and the bindings won't change either as they're correct. > > So we have to put an exception for the MPC8349E-mITX-compatible > MCUs. > > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html > [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- > drivers/of/base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Any issues with this or the second patch? Can we merge them? Thanks, > diff --git a/drivers/of/base.c b/drivers/of/base.c > index ad8ac1a..a726464 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -410,7 +410,7 @@ struct of_modalias_table { > char *modalias; > }; > static struct of_modalias_table of_modalias_table[] = { > - /* Empty for now; add entries as needed */ > + { "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" }, > }; > > /** > -- > 1.5.6.3
Hi Anton, On Tue, 30 Sep 2008 16:44:24 +0400, Anton Vorontsov wrote: > On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote: > > of/base.c matches on the first (most specific) entries, which isn't > > quite practical but it was discussed[1] that this won't change. > > > > The bindings specifies verbose information for the devices, but > > it doesn't fit in the I2C ID's 20 characters limit. The limit won't > > change[2], and the bindings won't change either as they're correct. > > > > So we have to put an exception for the MPC8349E-mITX-compatible > > MCUs. > > > > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html > > [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html > > > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > --- > > drivers/of/base.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > Any issues with this or the second patch? Can we merge them? I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
On Wed, Oct 01, 2008 at 01:22:48PM +0200, Jean Delvare wrote: > Hi Anton, > > On Tue, 30 Sep 2008 16:44:24 +0400, Anton Vorontsov wrote: > > On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote: > > > of/base.c matches on the first (most specific) entries, which isn't > > > quite practical but it was discussed[1] that this won't change. > > > > > > The bindings specifies verbose information for the devices, but > > > it doesn't fit in the I2C ID's 20 characters limit. The limit won't > > > change[2], and the bindings won't change either as they're correct. > > > > > > So we have to put an exception for the MPC8349E-mITX-compatible > > > MCUs. > > > > > > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html > > > [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html > > > > > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > > --- > > > drivers/of/base.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > Any issues with this or the second patch? Can we merge them? > > I do not have the time to review these patches (and, honestly, have no > interest in them.) So I will not merge them but I have no objection to > them being merged by somebody else. Ok, thanks for the sincerity.. ;-) Kumar, could you pick up the two patches via the patchworks? [1/2] OF: add fsl,mcu-mpc8349emitx to the exception list http://patchwork.ozlabs.org/patch/1105/ [2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver http://patchwork.ozlabs.org/patch/1106/ Or should I resend them to you? Or should I resend them to Andrew? Thanks,
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote: [...] > > > Any issues with this or the second patch? Can we merge them? > > > > I do not have the time to review these patches (and, honestly, have no > > interest in them.) So I will not merge them but I have no objection to > > them being merged by somebody else. > > Ok, thanks for the sincerity.. ;-) > > Kumar, could you pick up the two patches via the patchworks? > > [1/2] OF: add fsl,mcu-mpc8349emitx to the exception list > http://patchwork.ozlabs.org/patch/1105/ > > [2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver > http://patchwork.ozlabs.org/patch/1106/ > > Or should I resend them to you? Or should I resend them to Andrew? Ping?
On Mon, Oct 06, 2008 at 09:28:31PM +0400, Anton Vorontsov wrote: > On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote: > [...] > > > > Any issues with this or the second patch? Can we merge them? > > > > > > I do not have the time to review these patches (and, honestly, have no > > > interest in them.) So I will not merge them but I have no objection to > > > them being merged by somebody else. > > > > Ok, thanks for the sincerity.. ;-) > > > > Kumar, could you pick up the two patches via the patchworks? > > > > [1/2] OF: add fsl,mcu-mpc8349emitx to the exception list > > http://patchwork.ozlabs.org/patch/1105/ > > Since I've been involved with the i2c of bindings, I can pick this one up. > > [2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver > > http://patchwork.ozlabs.org/patch/1106/ But I'm not involved enough with this one, so it should go through kumar. g.
On Mon, Oct 06, 2008 at 11:31:58AM -0600, Grant Likely wrote: > On Mon, Oct 06, 2008 at 09:28:31PM +0400, Anton Vorontsov wrote: > > On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote: > > [...] > > > > > Any issues with this or the second patch? Can we merge them? > > > > > > > > I do not have the time to review these patches (and, honestly, have no > > > > interest in them.) So I will not merge them but I have no objection to > > > > them being merged by somebody else. > > > > > > Ok, thanks for the sincerity.. ;-) > > > > > > Kumar, could you pick up the two patches via the patchworks? > > > > > > [1/2] OF: add fsl,mcu-mpc8349emitx to the exception list > > > http://patchwork.ozlabs.org/patch/1105/ > > > > > Since I've been involved with the i2c of bindings, I can pick this one up. Much appreciated, thanks! > > > [2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver > > > http://patchwork.ozlabs.org/patch/1106/ > > But I'm not involved enough with this one, so it should go through > kumar. That's fine, the first and second patches could go separate trees since it won't break the build.
On Sep 23, 2008, at 9:12 AM, Anton Vorontsov wrote: > of/base.c matches on the first (most specific) entries, which isn't > quite practical but it was discussed[1] that this won't change. > > The bindings specifies verbose information for the devices, but > it doesn't fit in the I2C ID's 20 characters limit. The limit won't > change[2], and the bindings won't change either as they're correct. > > So we have to put an exception for the MPC8349E-mITX-compatible > MCUs. > > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html > [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- > drivers/of/base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) applied. - k
diff --git a/drivers/of/base.c b/drivers/of/base.c index ad8ac1a..a726464 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -410,7 +410,7 @@ struct of_modalias_table { char *modalias; }; static struct of_modalias_table of_modalias_table[] = { - /* Empty for now; add entries as needed */ + { "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" }, }; /**
of/base.c matches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change. The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct. So we have to put an exception for the MPC8349E-mITX-compatible MCUs. [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- drivers/of/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)