Message ID | 1373357007-30785-2-git-send-email-tiejun.chen@windriver.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Scott Wood |
Headers | show |
> -----Original Message----- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+bharat.bhushan=freescale.com@lists.ozlabs.org] On Behalf Of Tiejun Chen > Sent: Tuesday, July 09, 2013 1:33 PM > To: benh@kernel.crashing.org > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: [v3][PATCH 1/8] powerpc/book3e: rename interrupt_end_book3e with > __end_interrupts > > We can rename 'interrupt_end_book3e' with '__end_interrupts' then book3s/book3e > can share this unique label to make sure we can use this conveniently. I think we can be consistent with start and end names, no? -Bharat > > Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com> > --- > arch/powerpc/kernel/exceptions-64e.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64e.S > b/arch/powerpc/kernel/exceptions-64e.S > index 645170a..a518e48 100644 > --- a/arch/powerpc/kernel/exceptions-64e.S > +++ b/arch/powerpc/kernel/exceptions-64e.S > @@ -309,8 +309,8 @@ interrupt_base_book3e: /* fake > trap */ > EXCEPTION_STUB(0x300, hypercall) > EXCEPTION_STUB(0x320, ehpriv) > > - .globl interrupt_end_book3e > -interrupt_end_book3e: > + .globl __end_interrupts > +__end_interrupts: > > /* Critical Input Interrupt */ > START_EXCEPTION(critical_input); > @@ -493,7 +493,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC) > beq+ 1f > > LOAD_REG_IMMEDIATE(r14,interrupt_base_book3e) > - LOAD_REG_IMMEDIATE(r15,interrupt_end_book3e) > + LOAD_REG_IMMEDIATE(r15,__end_interrupts) > cmpld cr0,r10,r14 > cmpld cr1,r10,r15 > blt+ cr0,1f > @@ -559,7 +559,7 @@ kernel_dbg_exc: > beq+ 1f > > LOAD_REG_IMMEDIATE(r14,interrupt_base_book3e) > - LOAD_REG_IMMEDIATE(r15,interrupt_end_book3e) > + LOAD_REG_IMMEDIATE(r15,__end_interrupts) > cmpld cr0,r10,r14 > cmpld cr1,r10,r15 > blt+ cr0,1f > -- > 1.7.9.5 > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On 07/10/2013 01:17 PM, Bhushan Bharat-R65777 wrote: > > >> -----Original Message----- >> From: Linuxppc-dev [mailto:linuxppc-dev- >> bounces+bharat.bhushan=freescale.com@lists.ozlabs.org] On Behalf Of Tiejun Chen >> Sent: Tuesday, July 09, 2013 1:33 PM >> To: benh@kernel.crashing.org >> Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: [v3][PATCH 1/8] powerpc/book3e: rename interrupt_end_book3e with >> __end_interrupts >> >> We can rename 'interrupt_end_book3e' with '__end_interrupts' then book3s/book3e >> can share this unique label to make sure we can use this conveniently. > > I think we can be consistent with start and end names, no? Are you saying to rename 'interrupt_base_book3e' with '__base_interrupts' here? But seems optional since book3s have no this similar start label, so I'd like to keep that as original now. Lets listen other comments firstly. Tiejun
On Tue, 2013-07-09 at 16:03 +0800, Tiejun Chen wrote: > We can rename 'interrupt_end_book3e' with '__end_interrupts' then > book3s/book3e can share this unique label to make sure we can use > this conveniently. > > Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com> What users of this do you plan to share between book3s and book3e? I'm not seeing any existing book3s users that are obviously applicable to book3e -- they mainly involve copying exception vectors which we shouldn't need to do. -Scott
diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S index 645170a..a518e48 100644 --- a/arch/powerpc/kernel/exceptions-64e.S +++ b/arch/powerpc/kernel/exceptions-64e.S @@ -309,8 +309,8 @@ interrupt_base_book3e: /* fake trap */ EXCEPTION_STUB(0x300, hypercall) EXCEPTION_STUB(0x320, ehpriv) - .globl interrupt_end_book3e -interrupt_end_book3e: + .globl __end_interrupts +__end_interrupts: /* Critical Input Interrupt */ START_EXCEPTION(critical_input); @@ -493,7 +493,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC) beq+ 1f LOAD_REG_IMMEDIATE(r14,interrupt_base_book3e) - LOAD_REG_IMMEDIATE(r15,interrupt_end_book3e) + LOAD_REG_IMMEDIATE(r15,__end_interrupts) cmpld cr0,r10,r14 cmpld cr1,r10,r15 blt+ cr0,1f @@ -559,7 +559,7 @@ kernel_dbg_exc: beq+ 1f LOAD_REG_IMMEDIATE(r14,interrupt_base_book3e) - LOAD_REG_IMMEDIATE(r15,interrupt_end_book3e) + LOAD_REG_IMMEDIATE(r15,__end_interrupts) cmpld cr0,r10,r14 cmpld cr1,r10,r15 blt+ cr0,1f
We can rename 'interrupt_end_book3e' with '__end_interrupts' then book3s/book3e can share this unique label to make sure we can use this conveniently. Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com> --- arch/powerpc/kernel/exceptions-64e.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)