| Message ID | 1377275210-25194-1-git-send-email-trini@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Tom, On Friday 23 August 2013 09:56 PM, Tom Rini wrote: > Test on Beaglebone white over cpsw, usb ether and SD card (read and > write), performance increased, crc32 of data matches. > > Signed-off-by: Tom Rini <trini@ti.com> > --- > arch/arm/cpu/armv7/am33xx/board.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c > index 2ea3d69..c261af5 100644 > --- a/arch/arm/cpu/armv7/am33xx/board.c > +++ b/arch/arm/cpu/armv7/am33xx/board.c > @@ -225,3 +225,11 @@ void s_init(void) > sdram_init(); > #endif > } > + > +#ifndef CONFIG_SYS_DCACHE_OFF > +void enable_caches(void) > +{ > + /* Enable D-cache. I-cache is already enabled in start.S */ > + dcache_enable(); > +} > +#endif /* !CONFIG_SYS_DCACHE_OFF */ This is fine. Do we have secure devices here ? If so, we should take care of setting the domains permissions for avoiding prefetch aborts. As it was done for OMAP using arm_init_domains. So that function and the above should be executed on am33xx as well. Thanks to Lokesh for reminding this. Regards, Sricharan
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/30/2013 12:50 AM, Sricharan R wrote: > Hi Tom, > > On Friday 23 August 2013 09:56 PM, Tom Rini wrote: >> Test on Beaglebone white over cpsw, usb ether and SD card (read and >> write), performance increased, crc32 of data matches. >> >> Signed-off-by: Tom Rini <trini@ti.com> >> --- >> arch/arm/cpu/armv7/am33xx/board.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c >> index 2ea3d69..c261af5 100644 >> --- a/arch/arm/cpu/armv7/am33xx/board.c >> +++ b/arch/arm/cpu/armv7/am33xx/board.c >> @@ -225,3 +225,11 @@ void s_init(void) >> sdram_init(); >> #endif >> } >> + >> +#ifndef CONFIG_SYS_DCACHE_OFF >> +void enable_caches(void) >> +{ >> + /* Enable D-cache. I-cache is already enabled in start.S */ >> + dcache_enable(); >> +} >> +#endif /* !CONFIG_SYS_DCACHE_OFF */ > This is fine. Do we have secure devices here ? > > If so, we should take care of setting the domains permissions for > avoiding prefetch aborts. As it was done for OMAP using > arm_init_domains. So that function and the above should be executed on > am33xx as well. > > Thanks to Lokesh for reminding this. Yes, but I can't easily test them. I'll see if arm_init_domains just works on non-HS devices (I know I had a failure pulling all the OMAP4 code over, but didn't try hard, just looked again at the "easy" path). - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSIQmFAAoJENk4IS6UOR1WkpUP/1dFyNkM9qk5xr37yBwmha/7 NbW0HYx2YyIHrEZ5W1KZJOXjaB6yQWtVAVKvcs2nrmo5GL+6e2ObY667EzrmxOlY UPcXguJ1TvtiMIH+TZjzTUudeIBOQU8Tj5y2ryauvebJGYr8vlzbF22Unc3I/ehO cRI49H573Yu+W0kReeM7lWel+uV2kx1Q4TjRqli5lj2vSjQijBEVhgdn3RQsjkVE ff8+4N6exzczUYzSjUUh5N5RDWQnQ6qAbDKW3fkVIfo7JsgxAz1zjyqZk7j7cBAL Xo28W4wtDY2HcwFs2wl3SlYly2Kvx+qY7IAbWhULaV5NbpNMn6ShUHO8W8fh4IDF bQckJ1UTek5Y4VEP+3PmOcWi0EPIuRxCtYenhZAbweaUZE+YyBUCfunM85BH+NuJ G68T7+4gNas1KFCMLFzUXFpxAN25erH5kh3A6CNbEJLhvhq+kv+zAHb/3nOO2N30 5OuyxKlQRNDZI7M/JYaxAB+8WAqzkOaAx25+ZnrBVRD6CmtrQ+67YePQlLhJamYB nBZn/qM03JqsbacntEgL+b7gGqS62OM8ivyUegUJudfXSWfn9XZoL6ilISeezCj0 +/7jAdFDk0h2SYOhmp8zUFigsWzn7QsF3AIgBbikYZUJ9jBGbwUSc8+YaDuM79nI LtEUu/4BbWlzKrpVC4wT =tpnc -----END PGP SIGNATURE-----
On Fri, Aug 30, 2013 at 05:07:17PM -0400, Tom Rini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 08/30/2013 12:50 AM, Sricharan R wrote: > > Hi Tom, > > > > On Friday 23 August 2013 09:56 PM, Tom Rini wrote: > >> Test on Beaglebone white over cpsw, usb ether and SD card (read and > >> write), performance increased, crc32 of data matches. > >> > >> Signed-off-by: Tom Rini <trini@ti.com> > >> --- > >> arch/arm/cpu/armv7/am33xx/board.c | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c > >> index 2ea3d69..c261af5 100644 > >> --- a/arch/arm/cpu/armv7/am33xx/board.c > >> +++ b/arch/arm/cpu/armv7/am33xx/board.c > >> @@ -225,3 +225,11 @@ void s_init(void) > >> sdram_init(); > >> #endif > >> } > >> + > >> +#ifndef CONFIG_SYS_DCACHE_OFF > >> +void enable_caches(void) > >> +{ > >> + /* Enable D-cache. I-cache is already enabled in start.S */ > >> + dcache_enable(); > >> +} > >> +#endif /* !CONFIG_SYS_DCACHE_OFF */ > > This is fine. Do we have secure devices here ? > > > > If so, we should take care of setting the domains permissions for > > avoiding prefetch aborts. As it was done for OMAP using > > arm_init_domains. So that function and the above should be executed on > > am33xx as well. > > > > Thanks to Lokesh for reminding this. > > Yes, but I can't easily test them. I'll see if arm_init_domains just > works on non-HS devices (I know I had a failure pulling all the OMAP4 > code over, but didn't try hard, just looked again at the "easy" path). Yeah, that code as-is hangs the boards. So if the HS devices need something, it'll go with the rest of their patches until we're moving it upstream. But good to note a potential problem area!
On Fri, Aug 23, 2013 at 12:26:49PM -0400, Tom Rini wrote: > Test on Beaglebone white over cpsw, usb ether and SD card (read and > write), performance increased, crc32 of data matches. > > Signed-off-by: Tom Rini <trini@ti.com> Applied to u-boot-ti/master, thanks!
diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c index 2ea3d69..c261af5 100644 --- a/arch/arm/cpu/armv7/am33xx/board.c +++ b/arch/arm/cpu/armv7/am33xx/board.c @@ -225,3 +225,11 @@ void s_init(void) sdram_init(); #endif } + +#ifndef CONFIG_SYS_DCACHE_OFF +void enable_caches(void) +{ + /* Enable D-cache. I-cache is already enabled in start.S */ + dcache_enable(); +} +#endif /* !CONFIG_SYS_DCACHE_OFF */
Test on Beaglebone white over cpsw, usb ether and SD card (read and write), performance increased, crc32 of data matches. Signed-off-by: Tom Rini <trini@ti.com> --- arch/arm/cpu/armv7/am33xx/board.c | 8 ++++++++ 1 file changed, 8 insertions(+)