Message ID | 1385631509-627-1-git-send-email-alex.hung@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 28/11/13 09:38, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index e06992c..e347378 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -143,7 +143,7 @@ > * _PCT 8.4.4.1 Y > * _PDC 8.4.1 N > * _PDL 8.4.4.6 Y > - * _PIC 5.8.1 N > + * _PIC 5.8.1 Y > * _PIF 10.3.3 Y > * _PLD 6.1.8 Y > * _PMC 10.4.1 N > @@ -880,6 +880,24 @@ static int method_test_AEI(fwts_framework *fw) > } > > /* > + * Section 5.8 System Configuration Objects > + */ > +static int method_test_PIC(fwts_framework *fw) > +{ > + ACPI_OBJECT arg[1]; > + int i; > + > + arg[0].Type = ACPI_TYPE_INTEGER; > + for (i = 0; i < 3; i++) { > + arg[0].Integer.Value = i; > + method_evaluate_method(fw, METHOD_OPTIONAL, > + "_PIC", arg, 1, method_test_NULL_return, NULL); > + } > + > + return FWTS_OK; > +} > + > +/* > * Section 6.1 Device Identification Objects > */ > static int method_test_DDN(fwts_framework *fw) > @@ -4864,7 +4882,7 @@ static fwts_framework_minor_test method_tests[] = { > /* { method_test_REV, "Test _REV (Revision)." }, */ > > /* Section 5.8 System Configuration Objects */ > - /* { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, */ > + { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, > > /* Section 6.1 Device Identification Objects */ > > Acked-by: Colin Ian King <colin.king@canonical.com>
On Thu, Nov 28, 2013 at 5:38 PM, Alex Hung <alex.hung@canonical.com> wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index e06992c..e347378 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -143,7 +143,7 @@ > * _PCT 8.4.4.1 Y > * _PDC 8.4.1 N > * _PDL 8.4.4.6 Y > - * _PIC 5.8.1 N > + * _PIC 5.8.1 Y > * _PIF 10.3.3 Y > * _PLD 6.1.8 Y > * _PMC 10.4.1 N > @@ -880,6 +880,24 @@ static int method_test_AEI(fwts_framework *fw) > } > > /* > + * Section 5.8 System Configuration Objects > + */ > +static int method_test_PIC(fwts_framework *fw) > +{ > + ACPI_OBJECT arg[1]; > + int i; > + > + arg[0].Type = ACPI_TYPE_INTEGER; > + for (i = 0; i < 3; i++) { > + arg[0].Integer.Value = i; > + method_evaluate_method(fw, METHOD_OPTIONAL, > + "_PIC", arg, 1, method_test_NULL_return, NULL); > + } > + > + return FWTS_OK; > +} > + > +/* > * Section 6.1 Device Identification Objects > */ > static int method_test_DDN(fwts_framework *fw) > @@ -4864,7 +4882,7 @@ static fwts_framework_minor_test method_tests[] = { > /* { method_test_REV, "Test _REV (Revision)." }, */ > > /* Section 5.8 System Configuration Objects */ > - /* { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, */ > + { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, > > /* Section 6.1 Device Identification Objects */ > > -- > 1.8.1.2 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index e06992c..e347378 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -143,7 +143,7 @@ * _PCT 8.4.4.1 Y * _PDC 8.4.1 N * _PDL 8.4.4.6 Y - * _PIC 5.8.1 N + * _PIC 5.8.1 Y * _PIF 10.3.3 Y * _PLD 6.1.8 Y * _PMC 10.4.1 N @@ -880,6 +880,24 @@ static int method_test_AEI(fwts_framework *fw) } /* + * Section 5.8 System Configuration Objects + */ +static int method_test_PIC(fwts_framework *fw) +{ + ACPI_OBJECT arg[1]; + int i; + + arg[0].Type = ACPI_TYPE_INTEGER; + for (i = 0; i < 3; i++) { + arg[0].Integer.Value = i; + method_evaluate_method(fw, METHOD_OPTIONAL, + "_PIC", arg, 1, method_test_NULL_return, NULL); + } + + return FWTS_OK; +} + +/* * Section 6.1 Device Identification Objects */ static int method_test_DDN(fwts_framework *fw) @@ -4864,7 +4882,7 @@ static fwts_framework_minor_test method_tests[] = { /* { method_test_REV, "Test _REV (Revision)." }, */ /* Section 5.8 System Configuration Objects */ - /* { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, */ + { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, /* Section 6.1 Device Identification Objects */
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/method/method.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)