| Message ID | 1380567179-20174-1-git-send-email-santosh.shilimkar@ti.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Sep 30, 2013 at 02:52:59PM -0400, Santosh Shilimkar wrote:
> With CONFIG_ARM_LPAE=y spi driver throws below warning
Applied, thanks.
Hi, On Tue, Oct 1, 2013 at 3:48 AM, Mark Brown <broonie@kernel.org> wrote: > On Mon, Sep 30, 2013 at 02:52:59PM -0400, Santosh Shilimkar wrote: >> With CONFIG_ARM_LPAE=y spi driver throws below warning > > Applied, thanks. These warnings are showing up (again?), so wherever it was applied is not making it into -next. Did it fall between the cracks? -Olof
On Tue, Nov 12, 2013 at 10:38:13PM -0800, Olof Johansson wrote: > On Tue, Oct 1, 2013 at 3:48 AM, Mark Brown <broonie@kernel.org> wrote: > > Applied, thanks. > These warnings are showing up (again?), so wherever it was applied is > not making it into -next. Did it fall between the cracks? Looks lie it never got pushed and nobody looked at the warnings for over a month. Oh well, sorry about that.
On Wed, Nov 13, 2013 at 01:29:52PM +0000, Mark Brown wrote: > On Tue, Nov 12, 2013 at 10:38:13PM -0800, Olof Johansson wrote: > > On Tue, Oct 1, 2013 at 3:48 AM, Mark Brown <broonie@kernel.org> wrote: > > > > Applied, thanks. > > > These warnings are showing up (again?), so wherever it was applied is > > not making it into -next. Did it fall between the cracks? > > Looks lie it never got pushed and nobody looked at the warnings for over > a month. Oh well, sorry about that. No worries. I've been eyeing the warnings but not doing anything about it. Didn't notice that there was a patch until I started looking for existing patches to take care of it (and post patches where needed). -Olof
Mark, On Wednesday 13 November 2013 08:29 AM, Mark Brown wrote: > On Tue, Nov 12, 2013 at 10:38:13PM -0800, Olof Johansson wrote: >> On Tue, Oct 1, 2013 at 3:48 AM, Mark Brown <broonie@kernel.org> wrote: > >>> Applied, thanks. > >> These warnings are showing up (again?), so wherever it was applied is >> not making it into -next. Did it fall between the cracks? > > Looks lie it never got pushed and nobody looked at the warnings for over > a month. Oh well, sorry about that. > Are you going to push this one ? The warning is still showing up at 3.13-rc1. Regards, Santosh
On Sat, Nov 23, 2013 at 04:17:24PM -0500, Santosh Shilimkar wrote: > On Wednesday 13 November 2013 08:29 AM, Mark Brown wrote: > > Looks lie it never got pushed and nobody looked at the warnings for over > > a month. Oh well, sorry about that. > Are you going to push this one ? The warning is still showing up at > 3.13-rc1. It's a warning fix only so no, I was going to leave it till the next merge window. It'll appear in -next as soon as Linus releases -rc1.
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 8fbfe24..c91ad94 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -962,8 +962,8 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_clk; dev_info(&pdev->dev, "DMA: supported\n"); - dev_info(&pdev->dev, "DMA: RX channel: %d, TX channel: %d, " - "event queue: %d\n", dma_rx_chan, dma_tx_chan, + dev_info(&pdev->dev, "DMA: RX channel: %pa, TX channel: %pa, " + "event queue: %d\n", &dma_rx_chan, &dma_tx_chan, pdata->dma_event_q); }
With CONFIG_ARM_LPAE=y spi driver throws below warning drivers/spi/spi-davinci.c: In function ‘davinci_spi_probe’: drivers/spi/spi-davinci.c:965:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘resource_size_t’ [-Wformat] drivers/spi/spi-davinci.c:965:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘resource_size_t’ [-Wformat] Lets use '%pa' to properly print 'resource_size_t' type variables. Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- drivers/spi/spi-davinci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)