| Message ID | 1383850068-3903-1-git-send-email-mreitz@redhat.com |
|---|---|
| State | New |
| Headers | show |
Le Thursday 07 Nov 2013 à 19:47:48 (+0100), Max Reitz a écrit : > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..dde8e45 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1736,7 +1736,8 @@ > # @existing: QEMU should look for an existing image file. > # > # @absolute-paths: QEMU should create a new image with absolute paths > -# for the backing file. > +# for the backing file. If there is no backing file available, the new > +# image will not be backed either. > # > # Since: 1.1 > ## > -- > 1.8.4.2 > > Reviewed-by: Benoit Canet <benoit@irqsave.net>
On 11/07/2013 11:47 AM, Max Reitz wrote: > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> Trivial enough to include in 1.7, if desired.
于 2013/11/8 2:47, Max Reitz 写道: > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..dde8e45 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1736,7 +1736,8 @@ > # @existing: QEMU should look for an existing image file. > # > # @absolute-paths: QEMU should create a new image with absolute paths > -# for the backing file. > +# for the backing file. If there is no backing file available, the new > +# image will not be backed either. > # > # Since: 1.1 > ## > It seems 2nd line should start with space, how about: # @absolute-paths: QEMU should create a new image with absolute paths, # the new image would usually have a backing file. If # no backing file available, the new image will not be # backed either.
Am 07.11.2013 um 19:47 hat Max Reitz geschrieben: > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd Thanks, applied to the block branch. Kevin
diff --git a/qapi-schema.json b/qapi-schema.json index 81a375b..dde8e45 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1736,7 +1736,8 @@ # @existing: QEMU should look for an existing image file. # # @absolute-paths: QEMU should create a new image with absolute paths -# for the backing file. +# for the backing file. If there is no backing file available, the new +# image will not be backed either. # # Since: 1.1 ##
If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly. Signed-off-by: Max Reitz <mreitz@redhat.com> --- Follow-up to: - block/drive-mirror: Check for NULL backing_hd --- qapi-schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)