| Message ID | 1380878014-22088-2-git-send-email-pdeschrijver@nvidia.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Oct 04, 2013 at 12:12:40PM +0300, Peter De Schrijver wrote: > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> This is missing a commit description. > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c [...] > +const struct clk_ops tegra_clk_pllss_ops = { static? > +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, > + void __iomem *clk_base, unsigned long flags, > + unsigned long fixed_rate, > + struct tegra_clk_pll_params *pll_params, > + struct tegra_clk_pll_freq_table *freq_table, > + spinlock_t *lock) > +{ [...] > + pll = _tegra_init_pll(clk_base, NULL, fixed_rate, pll_params, > + pll_flags, freq_table, lock); > + > + if (IS_ERR(pll)) I'd leave out the blank line separating the assignment of pll and the check for validity. Grouping them together like that makes it immediately clear that they belong together. > + return ERR_CAST(pll); > + > + val = pll_readl_base(pll); > + > + if (val & (3 << 25)) { Same here. Also 3 << 25 could probably be a symbolic constant, something like PLLSS_REF_SRC_SEL_MASK perhaps? > + WARN(1, "Unknown parent selected for %s: %d\n", name, > + val >> 25); Similarly, this should be something like: (val & PLLSS_REF_SRC_SEL_MASK) >> PLLSS_REF_SRC_SEL_SHIFT > + kfree(pll); > + return ERR_PTR(-EINVAL); > + } > + _get_pll_mnp(pll, &cfg); Nit: I'd put a blank line before this, to separate the block and the function call. That is: } _get_pll_mnp(...); > + > + if (cfg.n > 1) { > + WARN(1, "%s should not be initialized\n", name); > + kfree(pll); > + return ERR_PTR(-EINVAL); > + } Is this really fatal? Can't we just configure the PLL from scratch? > + parent_rate = __clk_get_rate(parent); > + > + pll_params->vco_min = _clip_vco_min(pll_params->vco_min, parent_rate); > + > + cfg.m = _pll_fixed_mdiv(pll_params, parent_rate); > + cfg.n = cfg.m * pll_params->vco_min / parent_rate; > + > + for (i = 0; pll_params->pdiv_tohw[i].pdiv; i++) > + ; > + cfg.p = pll_params->pdiv_tohw[i-1].hw_val; Could use a blank line to separate them. Also what if .pdiv of the first entry is 0? The loop will terminate on the first run and i will be 0, so this would try to access pdiv_tohw[-1]. Can that ever happen? > + _update_pll_mnp(pll, &cfg); > + > + pll_writel_misc(PLLSS_MISC_DEFAULT, pll); > + pll_writel(PLLSS_CFG_DEFAULT, pll_params->ext_misc_reg[0], pll); > + pll_writel(PLLSS_CTRL1_DEFAULT, pll_params->ext_misc_reg[1], pll); > + pll_writel(PLLSS_CTRL1_DEFAULT, pll_params->ext_misc_reg[2], pll); > + > + val = pll_readl_base(pll); > + if (val & PLL_BASE_ENABLE) { > + if (val & BIT(pll_params->iddq_bit_idx)) { > + WARN(1, "%s is on but IDDQ set\n", name); > + kfree(pll); > + return ERR_PTR(-EINVAL); > + } > + } else > + val |= BIT(pll_params->iddq_bit_idx); > + > + val &= ~BIT(24); /* disable lock override */ Could use a symbolic name as well. PLLS_LOCK_OVERRIDE? > + pll_writel_base(val, pll); > + > + clk = _tegra_clk_register_pll(pll, name, parent_name, flags, > + &tegra_clk_pllss_ops); > + > + if (IS_ERR(clk)) I'd remove the blank line between the above two here as well. > +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, > + void __iomem *clk_base, unsigned long flags, > + unsigned long fixed_rate, > + struct tegra_clk_pll_params *pll_params, > + struct tegra_clk_pll_freq_table *freq_table, > + spinlock_t *lock); Nit: Parameter alignment looks funky here. I think you should either align them with the first argument on the first line or use only tabs to indent. Given that you don't align them anywhere else, I'd suggest using the latter for consistency. Thierry
On Thu, Oct 10, 2013 at 12:39:16PM +0200, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Oct 04, 2013 at 12:12:40PM +0300, Peter De Schrijver wrote: > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > > This is missing a commit description. > > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > [...] > > +const struct clk_ops tegra_clk_pllss_ops = { > > static? > While this could be static, I think conceptually it is exported. So I rather leave it not static. Unless you expect name space problems. > > +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, > > + void __iomem *clk_base, unsigned long flags, > > + unsigned long fixed_rate, > > + struct tegra_clk_pll_params *pll_params, > > + struct tegra_clk_pll_freq_table *freq_table, > > + spinlock_t *lock) > > +{ > [...] > > + pll = _tegra_init_pll(clk_base, NULL, fixed_rate, pll_params, > > + pll_flags, freq_table, lock); > > + > > + if (IS_ERR(pll)) > > I'd leave out the blank line separating the assignment of pll and the > check for validity. Grouping them together like that makes it > immediately clear that they belong together. > > > + return ERR_CAST(pll); > > + > > + val = pll_readl_base(pll); > > + > > + if (val & (3 << 25)) { > > Same here. Also 3 << 25 could probably be a symbolic constant, something > like PLLSS_REF_SRC_SEL_MASK perhaps? > > > + WARN(1, "Unknown parent selected for %s: %d\n", name, > > + val >> 25); > > Similarly, this should be something like: > > (val & PLLSS_REF_SRC_SEL_MASK) >> PLLSS_REF_SRC_SEL_SHIFT > > > + kfree(pll); > > + return ERR_PTR(-EINVAL); > > + } > > + _get_pll_mnp(pll, &cfg); > > Nit: I'd put a blank line before this, to separate the block and the > function call. That is: > > } > > _get_pll_mnp(...); > > > + > > + if (cfg.n > 1) { > > + WARN(1, "%s should not be initialized\n", name); > > + kfree(pll); > > + return ERR_PTR(-EINVAL); > > + } > > Is this really fatal? Can't we just configure the PLL from scratch? > At least in downstream it is. I'm assuming there is a good reason for this. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 10, 2013 at 12:39:16PM +0200, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Oct 04, 2013 at 12:12:40PM +0300, Peter De Schrijver wrote: > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > > This is missing a commit description. > > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > [...] > > +const struct clk_ops tegra_clk_pllss_ops = { > > static? > > > +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, > > + void __iomem *clk_base, unsigned long flags, > > + unsigned long fixed_rate, > > + struct tegra_clk_pll_params *pll_params, > > + struct tegra_clk_pll_freq_table *freq_table, > > + spinlock_t *lock) > > +{ > [...] > > + pll = _tegra_init_pll(clk_base, NULL, fixed_rate, pll_params, > > + pll_flags, freq_table, lock); > > + > > + if (IS_ERR(pll)) > > I'd leave out the blank line separating the assignment of pll and the > check for validity. Grouping them together like that makes it > immediately clear that they belong together. > > > + return ERR_CAST(pll); > > + > > + val = pll_readl_base(pll); > > + > > + if (val & (3 << 25)) { > > Same here. Also 3 << 25 could probably be a symbolic constant, something > like PLLSS_REF_SRC_SEL_MASK perhaps? > > > + WARN(1, "Unknown parent selected for %s: %d\n", name, > > + val >> 25); > > Similarly, this should be something like: > > (val & PLLSS_REF_SRC_SEL_MASK) >> PLLSS_REF_SRC_SEL_SHIFT > > > + kfree(pll); > > + return ERR_PTR(-EINVAL); > > + } > > + _get_pll_mnp(pll, &cfg); > > Nit: I'd put a blank line before this, to separate the block and the > function call. That is: > > } > > _get_pll_mnp(...); > > > + > > + if (cfg.n > 1) { > > + WARN(1, "%s should not be initialized\n", name); > > + kfree(pll); > > + return ERR_PTR(-EINVAL); > > + } > > Is this really fatal? Can't we just configure the PLL from scratch? > > > + parent_rate = __clk_get_rate(parent); > > + > > + pll_params->vco_min = _clip_vco_min(pll_params->vco_min, parent_rate); > > + > > + cfg.m = _pll_fixed_mdiv(pll_params, parent_rate); > > + cfg.n = cfg.m * pll_params->vco_min / parent_rate; > > + > > + for (i = 0; pll_params->pdiv_tohw[i].pdiv; i++) > > + ; > > + cfg.p = pll_params->pdiv_tohw[i-1].hw_val; > > Could use a blank line to separate them. Also what if .pdiv of the first > entry is 0? The loop will terminate on the first run and i will be 0, so > this would try to access pdiv_tohw[-1]. Can that ever happen? > That would be an error. This PLL type always has a post divider table. I will add a check. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 4cb2cec..87f0533 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -121,6 +121,33 @@ #define PMC_SATA_PWRGT_PLLE_IDDQ_VALUE BIT(5) #define PMC_SATA_PWRGT_PLLE_IDDQ_SWCTL BIT(4) +#define PLLSS_MISC_KCP 0 +#define PLLSS_MISC_KVCO 0 +#define PLLSS_MISC_SETUP 0 +#define PLLSS_EN_SDM 0 +#define PLLSS_EN_SSC 0 +#define PLLSS_EN_DITHER2 0 +#define PLLSS_EN_DITHER 1 +#define PLLSS_SDM_RESET 0 +#define PLLSS_CLAMP 0 +#define PLLSS_SDM_SSC_MAX 0 +#define PLLSS_SDM_SSC_MIN 0 +#define PLLSS_SDM_SSC_STEP 0 +#define PLLSS_SDM_DIN 0 +#define PLLSS_MISC_DEFAULT ((PLLSS_MISC_KCP << 25) | \ + (PLLSS_MISC_KVCO << 24) | \ + PLLSS_MISC_SETUP) +#define PLLSS_CFG_DEFAULT ((PLLSS_EN_SDM << 31) | \ + (PLLSS_EN_SSC << 30) | \ + (PLLSS_EN_DITHER2 << 29) | \ + (PLLSS_EN_DITHER << 28) | \ + (PLLSS_SDM_RESET) << 27 | \ + (PLLSS_CLAMP << 22)) +#define PLLSS_CTRL1_DEFAULT \ + ((PLLSS_SDM_SSC_MAX << 16) | PLLSS_SDM_SSC_MIN) +#define PLLSS_CTRL2_DEFAULT \ + ((PLLSS_SDM_SSC_STEP << 16) | PLLSS_SDM_DIN) + #define pll_readl(offset, p) readl_relaxed(p->clk_base + offset) #define pll_readl_base(p) pll_readl(p->params->base_reg, p) #define pll_readl_misc(p) pll_readl(p->params->misc_reg, p) @@ -1289,6 +1316,51 @@ static void clk_plle_tegra114_disable(struct clk_hw *hw) } #endif +static int clk_pllss_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct tegra_clk_pll *pll = to_clk_pll(hw); + struct tegra_clk_pll_freq_table cfg, old_cfg; + unsigned long flags = 0; + int ret = 0; + + ret = _pll_ramp_calc_pll(hw, &cfg, rate, parent_rate); + if (ret < 0) + return ret; + + if (pll->lock) + spin_lock_irqsave(pll->lock, flags); + + _get_pll_mnp(pll, &old_cfg); + + if (old_cfg.m != cfg.m || old_cfg.n != cfg.n || old_cfg.p != cfg.p) { + u32 val; + int state = clk_pll_is_enabled(hw); + + if (state) { + val = pll_readl_base(pll); + val &= ~PLL_BASE_ENABLE; + pll_writel_base(val, pll); + udelay(1); + } + + _update_pll_mnp(pll, &cfg); + + if (state) { + val = pll_readl_base(pll); + val |= PLL_BASE_ENABLE; + pll_writel_base(val, pll); + udelay(2); + clk_pll_wait_for_lock(pll); + } + } + + if (pll->lock) + spin_unlock_irqrestore(pll->lock, flags); + + return ret; +} + static struct tegra_clk_pll *_tegra_init_pll(void __iomem *clk_base, void __iomem *pmc, unsigned long fixed_rate, struct tegra_clk_pll_params *pll_params, u32 pll_flags, @@ -1690,3 +1762,99 @@ struct clk *tegra_clk_register_plle_tegra114(const char *name, return clk; } #endif + +const struct clk_ops tegra_clk_pllss_ops = { + .is_enabled = clk_pll_is_enabled, + .enable = clk_pll_iddq_enable, + .disable = clk_pll_iddq_disable, + .recalc_rate = clk_pll_recalc_rate, + .round_rate = clk_pll_ramp_round_rate, + .set_rate = clk_pllss_set_rate, +}; + +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, + void __iomem *clk_base, unsigned long flags, + unsigned long fixed_rate, + struct tegra_clk_pll_params *pll_params, + struct tegra_clk_pll_freq_table *freq_table, + spinlock_t *lock) +{ + struct tegra_clk_pll *pll; + struct clk *clk, *parent; + struct tegra_clk_pll_freq_table cfg; + unsigned long parent_rate; + u32 val, pll_flags; + int i; + + if (!pll_params->div_nmp) + return ERR_PTR(-EINVAL); + + parent = __clk_lookup(parent_name); + if (IS_ERR(parent)) { + WARN(1, "parent clk %s of %s must be registered first\n", + name, parent_name); + return ERR_PTR(-EINVAL); + } + + pll_flags = TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_USE_LOCK; + pll = _tegra_init_pll(clk_base, NULL, fixed_rate, pll_params, + pll_flags, freq_table, lock); + + if (IS_ERR(pll)) + return ERR_CAST(pll); + + val = pll_readl_base(pll); + + if (val & (3 << 25)) { + WARN(1, "Unknown parent selected for %s: %d\n", name, + val >> 25); + kfree(pll); + return ERR_PTR(-EINVAL); + } + _get_pll_mnp(pll, &cfg); + + if (cfg.n > 1) { + WARN(1, "%s should not be initialized\n", name); + kfree(pll); + return ERR_PTR(-EINVAL); + } + + parent_rate = __clk_get_rate(parent); + + pll_params->vco_min = _clip_vco_min(pll_params->vco_min, parent_rate); + + cfg.m = _pll_fixed_mdiv(pll_params, parent_rate); + cfg.n = cfg.m * pll_params->vco_min / parent_rate; + + for (i = 0; pll_params->pdiv_tohw[i].pdiv; i++) + ; + cfg.p = pll_params->pdiv_tohw[i-1].hw_val; + + _update_pll_mnp(pll, &cfg); + + pll_writel_misc(PLLSS_MISC_DEFAULT, pll); + pll_writel(PLLSS_CFG_DEFAULT, pll_params->ext_misc_reg[0], pll); + pll_writel(PLLSS_CTRL1_DEFAULT, pll_params->ext_misc_reg[1], pll); + pll_writel(PLLSS_CTRL1_DEFAULT, pll_params->ext_misc_reg[2], pll); + + val = pll_readl_base(pll); + if (val & PLL_BASE_ENABLE) { + if (val & BIT(pll_params->iddq_bit_idx)) { + WARN(1, "%s is on but IDDQ set\n", name); + kfree(pll); + return ERR_PTR(-EINVAL); + } + } else + val |= BIT(pll_params->iddq_bit_idx); + + val &= ~BIT(24); /* disable lock override */ + pll_writel_base(val, pll); + + clk = _tegra_clk_register_pll(pll, name, parent_name, flags, + &tegra_clk_pllss_ops); + + if (IS_ERR(clk)) + kfree(pll); + + return clk; +} diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h index 153d857..2912f57 100644 --- a/drivers/clk/tegra/clk.h +++ b/drivers/clk/tegra/clk.h @@ -310,6 +310,13 @@ struct clk *tegra_clk_register_plle_tegra114(const char *name, struct tegra_clk_pll_freq_table *freq_table, spinlock_t *lock); +struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, + void __iomem *clk_base, unsigned long flags, + unsigned long fixed_rate, + struct tegra_clk_pll_params *pll_params, + struct tegra_clk_pll_freq_table *freq_table, + spinlock_t *lock); + /** * struct tegra_clk_pll_out - PLL divider down clock *
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> --- drivers/clk/tegra/clk-pll.c | 168 +++++++++++++++++++++++++++++++++++++++++++ drivers/clk/tegra/clk.h | 7 ++ 2 files changed, 175 insertions(+), 0 deletions(-)