| Message ID | 525567B0.2060503@arm.com |
|---|---|
| State | New |
| Headers | show |
On 9 October 2013 15:26, Marcus Shawcroft wrote: > The test case add here: > > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html > > Introduced an unprototyped call to abort() resulting in failures due to > unexepected warnings in aarch64-none-elf cross testing. > > Committed to trunk as obvious. Thanks, I forgot to change that part when adding it to the testsuite. I think we should really use a VERIFY there. Jakub, can I fix the testcase on the 4.8 branch that was committed for http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00478.html? > Cheers > /Marcus > > 2013-10-09 Marcus Shawcroft <marcus.shawcroft@arm.com> > > * testsuite/20_util/shared_ptr/cons/58659.cc: Use __builtin_abort().
On Wed, Oct 09, 2013 at 04:12:21PM +0100, Jonathan Wakely wrote: > On 9 October 2013 15:26, Marcus Shawcroft wrote: > > The test case add here: > > > > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html > > > > Introduced an unprototyped call to abort() resulting in failures due to > > unexepected warnings in aarch64-none-elf cross testing. > > > > Committed to trunk as obvious. > > Thanks, I forgot to change that part when adding it to the testsuite. > I think we should really use a VERIFY there. > > Jakub, can I fix the testcase on the 4.8 branch that was committed for > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00478.html? Ok. Jakub
On 9 October 2013 16:15, Jakub Jelinek wrote: > On Wed, Oct 09, 2013 at 04:12:21PM +0100, Jonathan Wakely wrote: >> On 9 October 2013 15:26, Marcus Shawcroft wrote: >> > The test case add here: >> > >> > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html >> > >> > Introduced an unprototyped call to abort() resulting in failures due to >> > unexepected warnings in aarch64-none-elf cross testing. >> > >> > Committed to trunk as obvious. >> >> Thanks, I forgot to change that part when adding it to the testsuite. >> I think we should really use a VERIFY there. >> >> Jakub, can I fix the testcase on the 4.8 branch that was committed for >> http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00478.html? > > Ok. Thanks. The attached changes are committed to the trunk and 4.8 branch. 2013-10-09 Jonathan Wakely <jwakely.gcc@gmail.com> * testsuite/20_util/shared_ptr/cons/58659.cc: Use VERIFY instead of aborting.
diff --git a/libstdc++-v3/testsuite/20_util/shared_ptr/cons/58659.cc b/libstdc++-v3/testsuite/20_util/shared_ptr/cons/58659.cc index 5e7c730..1b823bc 100644 --- a/libstdc++-v3/testsuite/20_util/shared_ptr/cons/58659.cc +++ b/libstdc++-v3/testsuite/20_util/shared_ptr/cons/58659.cc @@ -48,7 +48,7 @@ namespace std void deallocate(value_type* p, size_t n) { if (n != 1 || p != (void*)storage || !allocated) - abort(); + __builtin_abort(); allocated = false; }
The test case add here: http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html Introduced an unprototyped call to abort() resulting in failures due to unexepected warnings in aarch64-none-elf cross testing. Committed to trunk as obvious. Cheers /Marcus 2013-10-09 Marcus Shawcroft <marcus.shawcroft@arm.com> * testsuite/20_util/shared_ptr/cons/58659.cc: Use __builtin_abort().