| Message ID | 245895a0777442b56ecea1453be041aa1b31c5a2.1380898983.git.jbenc@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, 2013-10-04 at 17:04 +0200, Jiri Benc wrote: > When sending out multicast messages, the source address in inet->mc_addr is > ignored and rewritten by an autoselected one. This is caused by a typo in > commit 813b3b5db831 ("ipv4: Use caller's on-stack flowi as-is in output > route lookups"). > > Signed-off-by: Jiri Benc <jbenc@redhat.com> > --- Nice catch ! Acked-by: Eric Dumazet <edumazet@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Benc <jbenc@redhat.com> Date: Fri, 4 Oct 2013 17:04:48 +0200 > When sending out multicast messages, the source address in inet->mc_addr is > ignored and rewritten by an autoselected one. This is caused by a typo in > commit 813b3b5db831 ("ipv4: Use caller's on-stack flowi as-is in output > route lookups"). > > Signed-off-by: Jiri Benc <jbenc@redhat.com> My bad :-) Applied and queued up for -stable, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 727f436..6011615 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2072,7 +2072,7 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *fl4) RT_SCOPE_LINK); goto make_route; } - if (fl4->saddr) { + if (!fl4->saddr) { if (ipv4_is_multicast(fl4->daddr)) fl4->saddr = inet_select_addr(dev_out, 0, fl4->flowi4_scope);
When sending out multicast messages, the source address in inet->mc_addr is ignored and rewritten by an autoselected one. This is caused by a typo in commit 813b3b5db831 ("ipv4: Use caller's on-stack flowi as-is in output route lookups"). Signed-off-by: Jiri Benc <jbenc@redhat.com> --- net/ipv4/route.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)