diff mbox

[1/1] i2c: mv64xxx: Remove redundant of_match_ptr

Message ID 1380542526-2943-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Sept. 30, 2013, 12:02 p.m. UTC
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/i2c/busses/i2c-mv64xxx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Oct. 1, 2013, 10:20 p.m. UTC | #1
On Mon, Sep 30, 2013 at 05:32:06PM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied to for-next, thanks! I hope you checked if you missed other
occurences, too. My pointing to mv64xxx was an example, not a complete
list.
Sachin Kamat Oct. 2, 2013, 4:51 p.m. UTC | #2
On 2 October 2013 03:50, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Sep 30, 2013 at 05:32:06PM +0530, Sachin Kamat wrote:
>> The data structure of_match_ptr() protects is always compiled in.
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Applied to for-next, thanks!

Thanks.

> I hope you checked if you missed other
> occurences, too. My pointing to mv64xxx was an example, not a complete
> list.

I checked all the files in the sub-system manually now and found one
other similar instance. Have sent out a patch for it.
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 7f3a474..f42d88a 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -909,7 +909,7 @@  static struct platform_driver mv64xxx_i2c_driver = {
 	.driver	= {
 		.owner	= THIS_MODULE,
 		.name	= MV64XXX_I2C_CTLR_NAME,
-		.of_match_table = of_match_ptr(mv64xxx_i2c_of_match_table),
+		.of_match_table = mv64xxx_i2c_of_match_table,
 	},
 };