diff mbox

pppd: needs mmu and shared objects

Message ID 1380532727.13663.1.camel@phoenix
State Accepted
Headers show

Commit Message

Axel Lin Sept. 30, 2013, 9:18 a.m. UTC
The plugin infrastructure is based on shared objects so it won't build
for static-only scenarios.
And the daemon uses fork() so MMU is required.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 package/pppd/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Peter Korsgaard Oct. 1, 2013, 7:37 p.m. UTC | #1
>>>>> "Axel" == Axel Lin <axel.lin@ingics.com> writes:

 Axel> The plugin infrastructure is based on shared objects so it won't build
 Axel> for static-only scenarios.
 Axel> And the daemon uses fork() so MMU is required.

 Axel> Signed-off-by: Axel Lin <axel.lin@ingics.com>
 Axel> ---
 Axel>  package/pppd/Config.in | 6 ++++++
 Axel>  1 file changed, 6 insertions(+)

 Axel> diff --git a/package/pppd/Config.in b/package/pppd/Config.in
 Axel> index 879b263..074c2fd 100644
 Axel> --- a/package/pppd/Config.in
 Axel> +++ b/package/pppd/Config.in
 Axel> @@ -1,10 +1,16 @@
 Axel>  config BR2_PACKAGE_PPPD
 Axel>  	bool "pppd"
 Axel> +	depends on !BR2_PREFER_STATIC_LIB
 Axel> +	depends on BR2_USE_MMU
 Axel>  	help
 Axel>  	  An implementation of the Point-to-point protocol.
 
 Axel>  	  http://www.samba.org/ppp/
 
 Axel> +comment "pppd requires a toolchain with dynamic library support"
 Axel> +	depends on BR2_PREFER_STATIC_LIB
 Axel> +	depends on BR2_USE_MMU
 Axel> +

This needs to go under the sub options otherwise they won't get properly
indented.

Committed with that fixed, thanks.
diff mbox

Patch

diff --git a/package/pppd/Config.in b/package/pppd/Config.in
index 879b263..074c2fd 100644
--- a/package/pppd/Config.in
+++ b/package/pppd/Config.in
@@ -1,10 +1,16 @@ 
 config BR2_PACKAGE_PPPD
 	bool "pppd"
+	depends on !BR2_PREFER_STATIC_LIB
+	depends on BR2_USE_MMU
 	help
 	  An implementation of the Point-to-point protocol.
 
 	  http://www.samba.org/ppp/
 
+comment "pppd requires a toolchain with dynamic library support"
+	depends on BR2_PREFER_STATIC_LIB
+	depends on BR2_USE_MMU
+
 config BR2_PACKAGE_PPPD_FILTER
 	depends on BR2_PACKAGE_PPPD
 	select BR2_PACKAGE_LIBPCAP