diff mbox

[v4,3/7] mirror: don't close target

Message ID 1380542578-2387-4-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Sept. 30, 2013, 12:02 p.m. UTC 
Let reference count manage target and don't call bdrv_close here.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/mirror.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Blake Oct. 1, 2013, 5:11 p.m. UTC | #1 
On 09/30/2013 06:02 AM, Fam Zheng wrote:
> Let reference count manage target and don't call bdrv_close here.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/mirror.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/mirror.c b/block/mirror.c
> index fdc7fa8..af6851f 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -479,7 +479,6 @@ immediate_exit:
>          }
>          bdrv_swap(s->target, s->common.bs);
>      }
> -    bdrv_close(s->target);
>      bdrv_unref(s->target);
>      block_job_completed(&s->common, ret);
>  }
>
diff mbox

Patch

diff --git a/block/mirror.c b/block/mirror.c
index fdc7fa8..af6851f 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -479,7 +479,6 @@  immediate_exit:
         }
         bdrv_swap(s->target, s->common.bs);
     }
-    bdrv_close(s->target);
     bdrv_unref(s->target);
     block_job_completed(&s->common, ret);
 }