| Message ID | 1380594702.9353.1.camel@phoenix |
|---|---|
| State | Accepted |
| Commit | 243fe9a7d9b19ab48df88e1493c2a4dacd1e91f3 |
| Headers | show |
Dear Axel Lin, On Tue, 01 Oct 2013 10:31:42 +0800, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Fix below build error: > > logrotate.o: In function `switch_user_permanently': > /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork' > logrotate.o: In function `removeLogFile': > /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork' > logrotate.o: In function `mailLog': > /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork' > /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork' > logrotate.o: In function `compressLogFile': > /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork' > collect2: ld returned 1 exit status > make[1]: *** [logrotate] Error 1 It's a minor comment, but I believe the log of the error could go within the commit log itself (i.e, before the --- separator). It really is part of the explanation of why the change is needed. Note that there is no need to resend this patch just for this reason, it was merely a suggestion for future patches. Thanks! Thomas
2013/10/1 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Dear Axel Lin, > > On Tue, 01 Oct 2013 10:31:42 +0800, Axel Lin wrote: >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> Fix below build error: >> >> logrotate.o: In function `switch_user_permanently': >> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork' >> logrotate.o: In function `removeLogFile': >> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork' >> logrotate.o: In function `mailLog': >> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork' >> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork' >> logrotate.o: In function `compressLogFile': >> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork' >> collect2: ld returned 1 exit status >> make[1]: *** [logrotate] Error 1 > > It's a minor comment, but I believe the log of the error could go > within the commit log itself (i.e, before the --- separator). It really > is part of the explanation of why the change is needed. > > Note that there is no need to resend this patch just for this reason, > it was merely a suggestion for future patches. Actually, I check git log before sending patches. Some commit log includes a link to the autobuild build log. But I don't find any commit log with build error so I didn't include the build error messages. I just add the error messages here to make it easier for review. Anyway, I will include the error message in commit log next time I send a patch. Regards, Axel
diff --git a/package/logrotate/Config.in b/package/logrotate/Config.in index 0d0ec61..bc7b295 100644 --- a/package/logrotate/Config.in +++ b/package/logrotate/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_LOGROTATE bool "logrotate" select BR2_PACKAGE_POPT depends on BR2_USE_WCHAR + depends on BR2_USE_MMU # fork() help A simple program to rotate logs.
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Fix below build error: logrotate.o: In function `switch_user_permanently': /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork' logrotate.o: In function `removeLogFile': /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork' logrotate.o: In function `mailLog': /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork' /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork' logrotate.o: In function `compressLogFile': /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork' collect2: ld returned 1 exit status make[1]: *** [logrotate] Error 1 package/logrotate/Config.in | 1 + 1 file changed, 1 insertion(+)