diff mbox

[1/2] i2c: mux: Remove redundant of_match_ptr

Message ID 1380512066-23681-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Sept. 30, 2013, 3:34 a.m. UTC
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Doug Anderson <dianders@chromium.org>
---
 drivers/i2c/muxes/i2c-arb-gpio-challenge.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Sept. 30, 2013, 10:52 a.m. UTC | #1
On Mon, Sep 30, 2013 at 09:04:25AM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Doug Anderson <dianders@chromium.org>

Can you do this subsystem wide? At least mv64xxx is affected as well.
Sachin Kamat Sept. 30, 2013, 10:55 a.m. UTC | #2
On 30 September 2013 16:22, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Sep 30, 2013 at 09:04:25AM +0530, Sachin Kamat wrote:
>> The data structure of_match_ptr() protects is always compiled in.
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Doug Anderson <dianders@chromium.org>
>
> Can you do this subsystem wide? At least mv64xxx is affected as well.

Sorry, I missed that. Will send a patch for that.
Wolfram Sang Oct. 1, 2013, 10:19 p.m. UTC | #3
On Mon, Sep 30, 2013 at 09:04:25AM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied to for-next, thanks!
diff mbox

Patch

diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c
index 74b41ae..cb9af93 100644
--- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c
+++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c
@@ -238,7 +238,7 @@  static struct platform_driver i2c_arbitrator_driver = {
 	.driver	= {
 		.owner	= THIS_MODULE,
 		.name	= "i2c-arb-gpio-challenge",
-		.of_match_table = of_match_ptr(i2c_arbitrator_of_match),
+		.of_match_table = i2c_arbitrator_of_match,
 	},
 };