| Message ID | 1379315863-22416-1-git-send-email-adam@jessamine.co.uk |
|---|---|
| State | New |
| Headers | show |
> --- > gcc/cp/pt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c > index 2ef160a..ed08dca 100644 > --- a/gcc/cp/pt.c > +++ b/gcc/cp/pt.c > @@ -21041,7 +21041,7 @@ static tree > make_auto_1 (tree name) > { > tree au = cxx_make_type (TEMPLATE_TYPE_PARM); > - TYPE_NAME (au) = build_decl (BUILTINS_LOCATION, > + TYPE_NAME (au) = build_decl (input_location, > TYPE_DECL, name, au); > TYPE_STUB_DECL (au) = TYPE_NAME (au); > TEMPLATE_TYPE_PARM_INDEX (au) = build_template_parm_index That's not a valid post to gcc-patches though. You need to explain what the patch does in a few words, post a ChangeLog entry and say how you tested it. See all the other messages on the list...
On 16.09.2013 09:02, Eric Botcazou wrote: >> --- >> gcc/cp/pt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c >> index 2ef160a..ed08dca 100644 >> --- a/gcc/cp/pt.c >> +++ b/gcc/cp/pt.c >> @@ -21041,7 +21041,7 @@ static tree >> make_auto_1 (tree name) >> { >> tree au = cxx_make_type (TEMPLATE_TYPE_PARM); >> - TYPE_NAME (au) = build_decl (BUILTINS_LOCATION, >> + TYPE_NAME (au) = build_decl (input_location, >> TYPE_DECL, name, au); >> TYPE_STUB_DECL (au) = TYPE_NAME (au); >> TEMPLATE_TYPE_PARM_INDEX (au) = build_template_parm_index > > That's not a valid post to gcc-patches though. You need to explain > what the > patch does in a few words, post a ChangeLog entry and say how you > tested it. > > See all the other messages on the list... > Apologies if this was out of context. This was a change suggested and reviewed by Jason (http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01114.html). It has been commited. The changelog happened to be a one liner which folded into the subject line.
> Apologies if this was out of context. This was a change suggested and > reviewed by Jason > (http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01114.html). Then don't repost it on gcc-patches, it is already available on gcc-cvs: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00473.html
On 16.09.2013 17:54, Eric Botcazou wrote: >> Apologies if this was out of context. This was a change suggested >> and >> reviewed by Jason >> (http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01114.html). > > Then don't repost it on gcc-patches, it is already available on > gcc-cvs: > http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00473.html > For some reason I had got it into my head that I should post to gcc-patches after any commit. After rereading "Write access policies" and "Checking in a change" I now realize I was mistaken. Sorry for the noise.
diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 2ef160a..ed08dca 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -21041,7 +21041,7 @@ static tree make_auto_1 (tree name) { tree au = cxx_make_type (TEMPLATE_TYPE_PARM); - TYPE_NAME (au) = build_decl (BUILTINS_LOCATION, + TYPE_NAME (au) = build_decl (input_location, TYPE_DECL, name, au); TYPE_STUB_DECL (au) = TYPE_NAME (au); TEMPLATE_TYPE_PARM_INDEX (au) = build_template_parm_index