| Message ID | 1379195690-6509-8-git-send-email-rth@twiddle.net |
|---|---|
| State | New |
| Headers | show |
On 14.09.2013 23:54, Richard Henderson wrote: > It was unused. Let's not overcomplicate things before we need them. > > Signed-off-by: Richard Henderson <rth@twiddle.net> > --- > tcg/aarch64/tcg-target.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index be6d05a..cc56fe5 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -543,10 +543,10 @@ static inline void tcg_out_rotl(TCGContext *s, TCGType ext, > } > > static inline void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, > - TCGReg rm, int shift_imm) > + TCGReg rm) > { > /* Using CMP alias SUBS wzr, Wn, Wm */ > - tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, shift_imm); > + tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, 0); > } > > static inline void tcg_out_cset(TCGContext *s, TCGType ext, > @@ -920,7 +920,7 @@ static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, > (is_read ? offsetof(CPUTLBEntry, addr_read) > : offsetof(CPUTLBEntry, addr_write))); > /* Perform the address comparison. */ > - tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3, 0); > + tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3); > *label_ptr = s->code_ptr; > /* If not equal, we jump to the slow path. */ > tcg_out_goto_cond_noaddr(s, TCG_COND_NE); > @@ -1259,13 +1259,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > > case INDEX_op_brcond_i64: > case INDEX_op_brcond_i32: > - tcg_out_cmp(s, ext, a0, a1, 0); > + tcg_out_cmp(s, ext, a0, a1); > tcg_out_goto_label_cond(s, a2, args[3]); > break; > > case INDEX_op_setcond_i64: > case INDEX_op_setcond_i32: > - tcg_out_cmp(s, ext, a1, a2, 0); > + tcg_out_cmp(s, ext, a1, a2); > tcg_out_cset(s, 0, a0, args[3]); > break; > > agreed. This is an artifact from a previous implementation of the tlb lookup. Reviewed-by: Claudio Fontana <claudio.fontana@linaro.org>
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index be6d05a..cc56fe5 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -543,10 +543,10 @@ static inline void tcg_out_rotl(TCGContext *s, TCGType ext, } static inline void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, - TCGReg rm, int shift_imm) + TCGReg rm) { /* Using CMP alias SUBS wzr, Wn, Wm */ - tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, shift_imm); + tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, 0); } static inline void tcg_out_cset(TCGContext *s, TCGType ext, @@ -920,7 +920,7 @@ static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, (is_read ? offsetof(CPUTLBEntry, addr_read) : offsetof(CPUTLBEntry, addr_write))); /* Perform the address comparison. */ - tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3, 0); + tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3); *label_ptr = s->code_ptr; /* If not equal, we jump to the slow path. */ tcg_out_goto_cond_noaddr(s, TCG_COND_NE); @@ -1259,13 +1259,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, case INDEX_op_brcond_i64: case INDEX_op_brcond_i32: - tcg_out_cmp(s, ext, a0, a1, 0); + tcg_out_cmp(s, ext, a0, a1); tcg_out_goto_label_cond(s, a2, args[3]); break; case INDEX_op_setcond_i64: case INDEX_op_setcond_i32: - tcg_out_cmp(s, ext, a1, a2, 0); + tcg_out_cmp(s, ext, a1, a2); tcg_out_cset(s, 0, a0, args[3]); break;
It was unused. Let's not overcomplicate things before we need them. Signed-off-by: Richard Henderson <rth@twiddle.net> --- tcg/aarch64/tcg-target.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)